Auction4Reputation.sol : Fix time restriction. #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-kaufman
approved these changes
Mar 14, 2019
dkent600
reviewed
Mar 14, 2019
| IERC20 _token, | ||
| address _wallet) | ||
| external | ||
| onlyOwner |
There was a problem hiding this comment.
Just curious: What is the use case for removing this?
There was a problem hiding this comment.
initialize function can be called one time only .
So no need to set onlyOwner
|
|
||
| contract UniversalSchemeInterface { | ||
|
|
||
| function updateParameters(bytes32 _hashedParameters) public; |
There was a problem hiding this comment.
Removing this function appears to address #387.
| hashedParameters = _hashedParameters; | ||
| } | ||
|
|
||
| contract UniversalScheme is UniversalSchemeInterface { |
There was a problem hiding this comment.
So all schemes are affected, not just the bootstrapping.
leviadam
approved these changes
Mar 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant ownership at rep schemes and universal schemes.
resolve #387