daofactory : support forge a dao from specific version #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyodfat
changed the title
ben-kaufman
reviewed
Nov 19, 2019
| App public app; | ||
| string public constant PACKAGE_NAME = "DAOstack"; | ||
| DAOTracker private daoTracker; | ||
| uint64[3] private packageVersion; |
Contributor
There was a problem hiding this comment.
Why is that a storage variable. Wouldn't it be cheaper (and better) to just pass it to the _forgeOrg function?
Contributor
Author
There was a problem hiding this comment.
it will be cheaper , though this is here due to "stack is too deep" issue .
ben-kaufman
reviewed
Nov 19, 2019
Contributor
ben-kaufman
left a comment
ben-kaufman
left a comment
There was a problem hiding this comment.
That looks fine, but I'm not sure this is a good way to work with the OpenZeppelin architecture...
ben-kaufman
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #686