Skip to content

JoinAndQuit updates #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2020
Merged

JoinAndQuit updates #740

merged 4 commits into from
Apr 30, 2020

Conversation

@orenyodfat
Copy link
Contributor

@orenyodfat orenyodfat commented Apr 29, 2020 •
edited
Loading

  • setFundingGoalReachedFlag is public
  • cannot propose for already a candidate
  • naming : fundingGoalDeadLine → fundingGoalDeadline

setFundingGoalReachedFlag is public
6c1141a 
cannot propose for already a candidate
@orenyodfat orenyodfat requested a review from leviadam as a code owner April 29, 2020 20:47
@orenyodfat orenyodfat mentioned this pull request Apr 29, 2020
Closed
jellegerbrandy
jellegerbrandy approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@jellegerbrandy jellegerbrandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks exactly right :-)

@orenyodfat orenyodfat merged commit f9e71c3 into arc-factory Apr 30, 2020
@orenyodfat orenyodfat deleted the common_updates branch April 30, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leviadam leviadam Awaiting requested review from leviadam

2 more reviewers

@jellegerbrandy jellegerbrandy jellegerbrandy approved these changes

@ben-kaufman ben-kaufman ben-kaufman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@orenyodfat @jellegerbrandy @ben-kaufman