Common token #753
Merged
Common token #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contracts/misc/CommonToken.sol
Outdated
| * | ||
| * See {ERC20-_burn}. | ||
| */ | ||
| function burn(uint256 amount) public onlyMinter { |
There was a problem hiding this comment.
I think we need:
burn(address account, uint256 amount) public onlyMinter {
_burn(account, amount)
}
|
Would be great to have a description in each new contract PR of the purpose and motivation behind the new contract. Otherwise one has to read the code and guess. |
jellegerbrandy
approved these changes
May 22, 2020
ben-kaufman
approved these changes
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An ERC20 token with an admin account that can arbitrarily mint and burn tokens in each account.