Skip to content

#171 - Make the revoke sync #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2021
Merged

#171 - Make the revoke sync #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 13 additions & 19 deletions packages/firebase/functions/src/subscriptions/business/revokeMemberships.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const db = firestore();
* Revokes all membership that are expired, but not yet revoked
*/
export const revokeMemberships = async (): Promise<void> => {
logger.info(`Beginning membership revoking for ${ new Date().getDate() }`);
logger.info(`Beginning membership revoking for ${ new Date().toDateString() }`);

// Only get the subscription cancelled by user, because the subscriptions
// canceled by payment failure should already be revoked
Expand All @@ -21,8 +21,6 @@ export const revokeMemberships = async (): Promise<void> => {
.where('revoked', '==', false)
.get() as firestore.QuerySnapshot<ISubscriptionEntity>;

const promiseArr: Promise<any>[] = [];

for (const subscriptionSnap of subscriptions.docs) {
const subscription = subscriptionSnap.data() as ISubscriptionEntity;

Expand All @@ -36,20 +34,18 @@ export const revokeMemberships = async (): Promise<void> => {
} else {
// If the subscription is pass it's due date: revoke it, If is not leave it be
if (subscription.dueDate.toDate() < new Date()) {
// eslint-disable-next-line no-loop-func
promiseArr.push((async () => {
// Add try/catch so that if one revoke fails
// the others won't be canceled because of it
try {
logger.info(`Revoking membership for subscription with id ${ subscription.id }`);

await revokeMembership(subscription);

logger.info(`Revoked membership ${ subscription.id }`);
} catch (e) {
logger.warn('Error occurred while trying to revoke subscription', e);
}
})());
// Add try/catch so that if one revoke fails
// the others won't be canceled because of it
try {
logger.info(`Revoking membership for subscription with id ${ subscription.id }`);

// eslint-disable-next-line no-await-in-loop
await revokeMembership(subscription);

logger.info(`Revoked membership ${ subscription.id }`);
} catch (e) {
logger.warn('Error occurred while trying to revoke subscription', e);
}
} else {
logger.debug('Skipping revoke for user canceled subscription', {
subscription
Expand All @@ -58,7 +54,5 @@ export const revokeMemberships = async (): Promise<void> => {
}
}

await Promise.all(promiseArr);

logger.info(`Memberships revoked successfully`);
};