Skip to content

Conversation

@arjundevarajan
Copy link
Contributor

@arjundevarajan arjundevarajan commented Dec 22, 2022

Signed-off-by: Arjun Devarajan arjun@scarf.sh

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
    It didn't seem appropriate for an alt text here but let me know if you'd like me to add one.
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This analytics pixel provides high-level web traffic insights for project maintainers so they can better understand how docs are being read and used. This pixel does not use cookies (or JavaScript at all) and is GDPR-compliant. It is a clear 1x1 pixel that won't affect page rendering or load times.

Issue reference

This is not referencing any existing issue because it is a result of direct conversation with Mark and Yaron at dapr but let me know if you'd like me to create an issue first.

This analytics pixel provides high-level web traffic insights for project maintainers so they can better understand how docs are being read and used. This pixel does not use cookies (or JavaScript at all) and is GDPR-compliant. It is a clear 1x1 pixel that won't affect page rendering or load times.

Signed-off-by: Arjun Devarajan <arjun@scarf.sh>
@arjundevarajan arjundevarajan requested review from a team as code owners December 22, 2022 20:34
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit e172996 into dapr:v1.9 Dec 22, 2022
@yaron2 yaron2 added this to the 1.10 milestone Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants