Skip to content

Conversation

@gcaracuel
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Updates https://docs.dapr.io/reference/resource-specs/subscription-schema/ to match CRDs properties from https://github.com/dapr/dapr/blob/release-1.12/charts/dapr/crds/subscription.yaml.

Changes some properties from the current docs which are wrong and prevents Subscriptions resources to be created from this docs.

Maybe hardest to catch is match is not optional as per -> https://github.com/dapr/dapr/blob/release-1.12/charts/dapr/crds/subscription.yaml#L134-L135

Issue reference

I do not have a reported issues and this change is small enough to not need it.

@gcaracuel gcaracuel requested review from a team as code owners November 29, 2023 10:37
Signed-off-by: gcaracuel <633810+gcaracuel@users.noreply.github.com>
@gcaracuel gcaracuel force-pushed the fix/subscriptions_docs branch from 1fa152f to 6a8dec0 Compare November 29, 2023 10:38
@msfussell msfussell merged commit 6460169 into dapr:v1.12 Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants