Skip to content

Initial observability docs (concept + howto) #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 12, 2020
Merged

Initial observability docs (concept + howto) #431

merged 13 commits into from
Mar 12, 2020

Conversation

youngbupark
Copy link
Contributor

@youngbupark youngbupark commented Mar 12, 2020 •
edited by shalabhms
Loading

Description

This PR includes the below concepts and how-tos:

  • Add Observability concept readme
  • Add Observability/log concept doc
  • Add howto - set up azure monitor for metrics and logs
  • Add howto - set up Fluentd, Kibana, Elasticsearch for logs
  • Add howto - set up Prometheus and Grafana for metrics

Issue reference

#382
#385
#421

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

msfussell
msfussell reviewed Mar 12, 2020
View reviewed changes
concepts/observability/README.md
### Traces

* [Zipkin](../../howto/diagnose-with-tracing/zipkin.md)
* [Application Insights](../../howto/diagnose-with-tracing/azure-monitor.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link looks wrong. It should not point to Azure Monitor, correct?

msfussell
msfussell previously approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done a first pass review. It would be good to get someone to actually go over these How To steps now to make sure that they work and that they are clear

@youngbupark
Copy link
Contributor Author

@msfussell @shalabhms @AaronCrawfis Thank you so much for reviewing docs and add grafana docs!

@youngbupark youngbupark merged commit fdb5d93 into master Mar 12, 2020
@youngbupark youngbupark deleted the youngp/add-observability branch March 12, 2020 15:23
@youngbupark youngbupark mentioned this pull request Mar 12, 2020
Merged
3 tasks
@yaron2 yaron2 mentioned this pull request Mar 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msfussell msfussell msfussell left review comments

@amanbha amanbha Awaiting requested review from amanbha

@yaron2 yaron2 Awaiting requested review from yaron2

+2 more reviewers

@shalabhms shalabhms shalabhms approved these changes

@AaronCrawfis AaronCrawfis AaronCrawfis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@youngbupark @msfussell @shalabhms @AaronCrawfis