- 
                Notifications
    You must be signed in to change notification settings 
- Fork 778
docs: update max-body-size documentation #4873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
closes dapr#4670 Signed-off-by: Mike Nguyen <hey@mike.ee>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikeee - Some comments
| - The `dapr.io/http-max-request-size` annotation, or | ||
| - The `--dapr-http-max-request-size` flag. | ||
| {{% alert title="Note" color="primary" %}} | ||
| The existing flag/annotation `dapr-http-max-request-size` has been deprecated and replaced with the below. It will be removed in the next release. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The existing flag/annotation `dapr-http-max-request-size` has been deprecated and replaced with the below. It will be removed in the next release. | |
| The flag/annotation `dapr-http-max-request-size` has been deprecated and replaced with the `max-body-size` flag/annotation. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikeee - Can you update the table in this article https://v1-16.docs.dapr.io/operations/support/breaking-changes-and-deprecations#Announced%20deprecations which is the list of deprecations. You can add announcement date of 1.14.0 and removal in 1.17.0. This is about preventing comments hidden in the docs about when etc.
        
          
                daprdocs/content/en/operations/configuration/increase-request-size.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
      …size.md Signed-off-by: Mark Fussell <markfussell@gmail.com>
cdc2d1d    to
    345e71b      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #4670
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Issue reference