Skip to content

Conversation

@mikeee
Copy link
Member

@mikeee mikeee commented Sep 10, 2025

closes #4670

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

closes dapr#4670

Signed-off-by: Mike Nguyen <hey@mike.ee>
@mikeee mikeee requested review from a team as code owners September 10, 2025 17:16
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeee - Some comments

- The `dapr.io/http-max-request-size` annotation, or
- The `--dapr-http-max-request-size` flag.
{{% alert title="Note" color="primary" %}}
The existing flag/annotation `dapr-http-max-request-size` has been deprecated and replaced with the below. It will be removed in the next release.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The existing flag/annotation `dapr-http-max-request-size` has been deprecated and replaced with the below. It will be removed in the next release.
The flag/annotation `dapr-http-max-request-size` has been deprecated and replaced with the `max-body-size` flag/annotation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeee - Can you update the table in this article https://v1-16.docs.dapr.io/operations/support/breaking-changes-and-deprecations#Announced%20deprecations which is the list of deprecations. You can add announcement date of 1.14.0 and removal in 1.17.0. This is about preventing comments hidden in the docs about when etc.

msfussell and others added 2 commits September 11, 2025 09:21
…size.md

Signed-off-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Mike Nguyen <hey@mike.ee>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 4867d9d into dapr:v1.16 Sep 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants