Skip to content

Conversation

@bibryam
Copy link
Contributor

@bibryam bibryam commented Sep 10, 2025

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

  • Expand requirements with internal topic details
  • Also added 'How the Outbox Works' section with an image

Issue reference

#4032

…ernal topic details

Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
@bibryam bibryam requested review from a team as code owners September 10, 2025 18:21
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with comments

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep this file source code and make this consistent with styling, can you add a slide after slide 39 in this deck https://docs.google.com/presentation/d/1q70WNp4OEstpwgDhg7gXRAud2pu68RYAZrwQK9_sZGk/edit?slide=id.p39#slide=id.p39.
Also can you update the current diagram (which is slide 39) as part of this PR. @marcduiker can help here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I am trying to understand is, do the dotted lined represent transaction boundaries or not? If so I would say this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll redraw the diagram in Dapr style and label the transaction boundary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcduiker - Will you do that on a separate PR or on this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has been replaced in this PR

bibryam and others added 11 commits September 11, 2025 16:44
…ate-management/howto-outbox.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
…ate-management/howto-outbox.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
…ate-management/howto-outbox.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
…ate-management/howto-outbox.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
…ate-management/howto-outbox.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
…ate-management/howto-outbox.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
…ate-management/howto-outbox.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
…ate-management/howto-outbox.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
Applied suggestions from the review manually.

Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 2f7d17d into dapr:v1.16 Sep 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants