Skip to content

Fix dependencies multi app build and add proper test deps #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 21, 2025
Merged

Fix dependencies multi app build and add proper test deps #1572

merged 6 commits into from
Oct 21, 2025

Conversation

@artur-ciocanu
Copy link
Contributor

@artur-ciocanu artur-ciocanu commented Oct 19, 2025 •
edited
Loading

Description

In some instances the build was failing because of missing JARs when build the test containers in examples module. This PR ensures that we are relying on verify phase to ensure all the JARs are present. Also there is a tiny fix to add proper <scope>test</scope> to different test dependencies.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artur-ciocanu artur-ciocanu requested review from a team as code owners October 19, 2025 18:01
@mcruzdev
Copy link
Contributor

mcruzdev commented Oct 19, 2025 •
edited
Loading

@artur-ciocanu this one #1574 solves this pipeline issue.

@artur-ciocanu artur-ciocanu changed the title Force Jackson version to override the SB Jackson version Fix dependencies for Jackson and ensure proper test deps Oct 20, 2025
@artur-ciocanu
Copy link
Contributor Author

@dapr/approvers-java-sdk and @dapr/maintainers-java-sdk could you please review and approve. This is another PR that gets us closer to a more sane Maven config.

Thank you.

salaboy
salaboy reviewed Oct 20, 2025
View reviewed changes
salaboy
salaboy reviewed Oct 20, 2025
View reviewed changes
@artur-ciocanu
Force Jackson version to override the SB Jackson version
0e4b5f6 
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
@artur-ciocanu
Move all the Jackson deps to parent POM.
863c334 
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
@artur-ciocanu
Ensure app JAR build order
55f7fae 
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
@artur-ciocanu
Remove explicit Jackson from sdk-tests module.
19b021c 
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
@artur-ciocanu
Make sure <scope>test</scope> is used for test dependencies.
4ef9978 
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
@artur-ciocanu
Remove extra Jackson modules.
7f42d54 
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
@artur-ciocanu artur-ciocanu changed the title Fix dependencies for Jackson and ensure proper test deps Fix dependencies multi app build and add proper test deps Oct 20, 2025
@artur-ciocanu
Copy link
Contributor Author

@salaboy @siri-varma could you please take a look, I have addressed the review comments. Thank you.

@dapr-bot dapr-bot merged commit c5dacde into dapr:master Oct 21, 2025
10 checks passed
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.44%. Comparing base (d759c53) to head (7f42d54).
⚠️ Report is 231 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1572      +/-   ##
============================================
+ Coverage     76.91%   78.44%   +1.53%     
- Complexity     1592     1929     +337     
============================================
  Files           145      216      +71     
  Lines          4843     5860    +1017     
  Branches        562      656      +94     
============================================
+ Hits           3725     4597     +872     
- Misses          821      926     +105     
- Partials        297      337      +40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@artur-ciocanu artur-ciocanu deleted the fix-jackson-version branch October 22, 2025 00:50
salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Oct 24, 2025
@artur-ciocanu @salaboy
Fix dependencies multi app build and add proper test deps (dapr#1572)
e423868 
* Force Jackson version to override the SB Jackson version

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Move all the Jackson deps to parent POM.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Ensure app JAR build order

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove explicit Jackson from sdk-tests module.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Make sure <scope>test</scope> is used for test dependencies.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove extra Jackson modules.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

---------

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Oct 24, 2025
@artur-ciocanu @salaboy
Fix dependencies multi app build and add proper test deps (dapr#1572)
69b2ccd 
* Force Jackson version to override the SB Jackson version

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Move all the Jackson deps to parent POM.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Ensure app JAR build order

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove explicit Jackson from sdk-tests module.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Make sure <scope>test</scope> is used for test dependencies.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove extra Jackson modules.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

---------

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Oct 24, 2025
@artur-ciocanu @salaboy
Fix dependencies multi app build and add proper test deps (dapr#1572)
b3eab62 
* Force Jackson version to override the SB Jackson version

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Move all the Jackson deps to parent POM.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Ensure app JAR build order

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove explicit Jackson from sdk-tests module.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Make sure <scope>test</scope> is used for test dependencies.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove extra Jackson modules.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

---------

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Oct 24, 2025
@artur-ciocanu @salaboy
Fix dependencies multi app build and add proper test deps (dapr#1572)
1e32212 
* Force Jackson version to override the SB Jackson version

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Move all the Jackson deps to parent POM.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Ensure app JAR build order

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove explicit Jackson from sdk-tests module.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Make sure <scope>test</scope> is used for test dependencies.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove extra Jackson modules.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

---------

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Oct 24, 2025
@artur-ciocanu @salaboy
Fix dependencies multi app build and add proper test deps (dapr#1572)
9502233 
* Force Jackson version to override the SB Jackson version

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Move all the Jackson deps to parent POM.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Ensure app JAR build order

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove explicit Jackson from sdk-tests module.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Make sure <scope>test</scope> is used for test dependencies.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove extra Jackson modules.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

---------

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Oct 24, 2025
@artur-ciocanu @salaboy
Fix dependencies multi app build and add proper test deps (dapr#1572)
793b551 
* Force Jackson version to override the SB Jackson version

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Move all the Jackson deps to parent POM.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Ensure app JAR build order

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove explicit Jackson from sdk-tests module.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Make sure <scope>test</scope> is used for test dependencies.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove extra Jackson modules.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

---------

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Oct 24, 2025
@artur-ciocanu @salaboy
Fix dependencies multi app build and add proper test deps (dapr#1572)
add4e96 
* Force Jackson version to override the SB Jackson version

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Move all the Jackson deps to parent POM.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Ensure app JAR build order

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove explicit Jackson from sdk-tests module.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Make sure <scope>test</scope> is used for test dependencies.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove extra Jackson modules.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

---------

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
dapr-bot pushed a commit that referenced this pull request Oct 24, 2025
@salaboy @artur-ciocanu
adding new method signature plus test (#1570)
6e9ee5a 
* adding new method signature plus test

Signed-off-by: salaboy <Salaboy@gmail.com>

* re adding imports

Signed-off-by: salaboy <Salaboy@gmail.com>

* fixing style

Signed-off-by: salaboy <Salaboy@gmail.com>

* checking empty metadata

Signed-off-by: salaboy <Salaboy@gmail.com>

* copy meta for safety and check if key is present

Signed-off-by: salaboy <Salaboy@gmail.com>

* Centralize Maven dependency version management (#1564)

Signed-off-by: salaboy <Salaboy@gmail.com>

* Fix dependencies multi app build and add proper test deps (#1572)

* Force Jackson version to override the SB Jackson version

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Move all the Jackson deps to parent POM.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Ensure app JAR build order

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove explicit Jackson from sdk-tests module.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Make sure <scope>test</scope> is used for test dependencies.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove extra Jackson modules.

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

---------

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>

* reverting pom

Signed-off-by: salaboy <Salaboy@gmail.com>

* fix codestyle

Signed-off-by: salaboy <Salaboy@gmail.com>

* using metaCopy

Signed-off-by: salaboy <Salaboy@gmail.com>

---------

Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@salaboy salaboy salaboy left review comments

@cicoyle cicoyle cicoyle approved these changes

+1 more reviewer

@mcruzdev mcruzdev mcruzdev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@artur-ciocanu @mcruzdev @salaboy @cicoyle @dapr-bot