Skip to content

Conversation

@mcruzdev
Copy link
Contributor

Description

This pull request adds examples for showing Outbox pattern with Java SDK and Spring.

https://docs.dapr.io/developing-applications/building-blocks/state-management/howto-outbox/

Issue reference

Closes #1579

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
@mcruzdev mcruzdev requested review from a team as code owners October 23, 2025 11:53
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
@mcruzdev
Copy link
Contributor Author

mcruzdev commented Oct 23, 2025

@dapr/maintainers-java-sdk @dapr/approvers-java-sdk With this one, I can update the Dapr documentation that actually looks old.

@salaboy @cicoyle @artur-ciocanu @siri-varma (I am not sure that the @dapr/maintainers-java-sdk @dapr/approvers-java-sdk are working as expected)

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
@salaboy
Copy link
Collaborator

salaboy commented Oct 23, 2025

@mcruzdev this is amazing!! thanks so much for contributing!

salaboy
salaboy previously approved these changes Oct 23, 2025
Copy link
Collaborator

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@mcruzdev
Copy link
Contributor Author

dapr/docs related dapr/docs#4924

siri-varma
siri-varma previously approved these changes Oct 24, 2025
Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcruzdev
Copy link
Contributor Author

mcruzdev commented Oct 24, 2025

I think CI issues are related

artur-ciocanu
artur-ciocanu previously approved these changes Oct 24, 2025
Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcruzdev love the changes! I have left a few tiny comments, my biggest concern is concurrent update to the list of events, other than that great job!

@mcruzdev mcruzdev dismissed stale reviews from artur-ciocanu, siri-varma, and salaboy via b021cbd October 24, 2025 04:10
@salaboy
Copy link
Collaborator

salaboy commented Oct 24, 2025

@mcruzdev if you can address the comments from @artur-ciocanu we can merge this asap

@mcruzdev
Copy link
Contributor Author

@mcruzdev if you can address the comments from @artur-ciocanu we can merge this asap

Hi @salaboy, comments addressed!

Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely PR!

@dapr-bot dapr-bot merged commit 3d950b0 into dapr:master Oct 24, 2025
10 checks passed
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.46%. Comparing base (d759c53) to head (b021cbd).
⚠️ Report is 233 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1582      +/-   ##
============================================
+ Coverage     76.91%   78.46%   +1.54%     
- Complexity     1592     1928     +336     
============================================
  Files           145      216      +71     
  Lines          4843     5860    +1017     
  Branches        562      656      +94     
============================================
+ Hits           3725     4598     +873     
- Misses          821      924     +103     
- Partials        297      338      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Outbox pattern examples and IT tests

5 participants