-
Notifications
You must be signed in to change notification settings - Fork 225
Add statestore example with Outbox pattern #1582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
|
@dapr/maintainers-java-sdk @dapr/approvers-java-sdk With this one, I can update the Dapr documentation that actually looks old. @salaboy @cicoyle @artur-ciocanu @siri-varma (I am not sure that the |
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
|
@mcruzdev this is amazing!! thanks so much for contributing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
|
dapr/docs related dapr/docs#4924 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I think CI issues are related |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcruzdev love the changes! I have left a few tiny comments, my biggest concern is concurrent update to the list of events, other than that great job!
sdk-tests/src/test/java/io/dapr/it/testcontainers/pubsub/outbox/ProductWebhookController.java
Show resolved
Hide resolved
...-examples/producer-app/src/test/java/io/dapr/springboot/examples/producer/ProducerAppIT.java
Show resolved
Hide resolved
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
b021cbd
|
@mcruzdev if you can address the comments from @artur-ciocanu we can merge this asap |
Hi @salaboy, comments addressed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely PR!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1582 +/- ##
============================================
+ Coverage 76.91% 78.46% +1.54%
- Complexity 1592 1928 +336
============================================
Files 145 216 +71
Lines 4843 5860 +1017
Branches 562 656 +94
============================================
+ Hits 3725 4598 +873
- Misses 821 924 +103
- Partials 297 338 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This pull request adds examples for showing Outbox pattern with Java SDK and Spring.
https://docs.dapr.io/developing-applications/building-blocks/state-management/howto-outbox/
Issue reference
Closes #1579
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: