Skip to content

Conversation

@salaboy
Copy link
Collaborator

@salaboy salaboy commented Oct 24, 2025

Description

Adding support for HttpPipeline to DaprContainer

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1584

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@salaboy salaboy requested review from a team as code owners October 24, 2025 10:52
@salaboy salaboy self-assigned this Oct 24, 2025
@salaboy salaboy force-pushed the 1584-middleware branch 2 times, most recently from 6c82a33 to 187f29e Compare October 24, 2025 10:59
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks to be all red, mind taking a look and fixing up CI to be green again?

Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
@salaboy
Copy link
Collaborator Author

salaboy commented Oct 24, 2025

@cicoyle checkstyle issue fixed

@siri-varma
Copy link
Contributor

@salaboy the codecov is failing. Can you please take a look ?

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.46%. Comparing base (d759c53) to head (1dea37e).
⚠️ Report is 234 commits behind head on master.

Files with missing lines Patch % Lines
...ain/java/io/dapr/testcontainers/Configuration.java 60.00% 2 Missing ⚠️
...main/java/io/dapr/testcontainers/HttpPipeline.java 80.00% 0 Missing and 1 partial ⚠️
...ntainers/converter/ConfigurationYamlConverter.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1585      +/-   ##
============================================
+ Coverage     76.91%   78.46%   +1.54%     
- Complexity     1592     1935     +343     
============================================
  Files           145      217      +72     
  Lines          4843     5883    +1040     
  Branches        562      660      +98     
============================================
+ Hits           3725     4616     +891     
- Misses          821      928     +107     
- Partials        297      339      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add HttpMiddleware support for Dapr container

4 participants