-
Couldn't load subscription status.
- Fork 225
Add gRPC support to Dapr testcontainer #1586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gRPC support to Dapr testcontainer #1586
Conversation
|
Hi @wlfgang thanks for this pull request, you need to sign-off your commit. |
Signed-off-by: wlfgang <wlfgang@westridgesystems.com>
2c7e916 to
e782e6b
Compare
Thanks @mcruzdev -- I've added the DCO to the commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Thanks a lot for your contribution @wlfgang!
|
@dapr/maintainers-java-sdk and @dapr/approvers-java-sdk let me know if you have any concerns merging this PR. |
testcontainers-dapr/src/test/java/io/dapr/testcontainers/DaprContainerTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌🏻 thanks for the PR here!
Signed-off-by: wlfgang <wlfgang@westridgesystems.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! ❤️
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1586 +/- ##
============================================
+ Coverage 76.91% 78.49% +1.57%
- Complexity 1592 1935 +343
============================================
Files 145 216 +71
Lines 4843 5872 +1029
Branches 562 659 +97
============================================
+ Hits 3725 4609 +884
- Misses 821 926 +105
- Partials 297 337 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Added a simple
withAppProtocolmethod to the DaprContainer test container which allows the user to specify--app-protocoleitherHTTPorGRPC, allowing projects to exercise gRPC services from integration tests.Issue reference
This will close #1578
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Let me know if there's documentation that should be updated, I can add that.