Skip to content

Conversation

@wlfgang
Copy link
Contributor

@wlfgang wlfgang commented Oct 24, 2025

Description

Added a simple withAppProtocol method to the DaprContainer test container which allows the user to specify --app-protocol either HTTP or GRPC, allowing projects to exercise gRPC services from integration tests.

Issue reference

This will close #1578

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Let me know if there's documentation that should be updated, I can add that.

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@wlfgang wlfgang requested review from a team as code owners October 24, 2025 18:23
@mcruzdev
Copy link
Contributor

Hi @wlfgang thanks for this pull request, you need to sign-off your commit.

Signed-off-by: wlfgang <wlfgang@westridgesystems.com>
@wlfgang wlfgang force-pushed the 1578-testcontainer-grpc-support branch from 2c7e916 to e782e6b Compare October 24, 2025 21:00
@wlfgang
Copy link
Contributor Author

wlfgang commented Oct 24, 2025

Hi @wlfgang thanks for this pull request, you need to sign-off your commit.

Thanks @mcruzdev -- I've added the DCO to the commit.

artur-ciocanu
artur-ciocanu previously approved these changes Oct 25, 2025
Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Thanks a lot for your contribution @wlfgang!

@artur-ciocanu
Copy link
Contributor

@dapr/maintainers-java-sdk and @dapr/approvers-java-sdk let me know if you have any concerns merging this PR.

cicoyle
cicoyle previously approved these changes Oct 27, 2025
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻 thanks for the PR here!

@cicoyle cicoyle added this to the v1.17 milestone Oct 27, 2025
@artur-ciocanu
Copy link
Contributor

@wlfgang could you please adjust the code based on @salaboy feedback.

Thank you.

Signed-off-by: wlfgang <wlfgang@westridgesystems.com>
@wlfgang wlfgang dismissed stale reviews from artur-ciocanu and cicoyle via 93701d2 October 27, 2025 20:19
@wlfgang
Copy link
Contributor Author

wlfgang commented Oct 27, 2025

@wlfgang could you please adjust the code based on @salaboy feedback.

Thank you.

Just made the fix, hopefully we should be good now!

Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@dapr-bot dapr-bot merged commit 56b9ef7 into dapr:master Oct 27, 2025
10 checks passed
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.49%. Comparing base (d759c53) to head (93701d2).
⚠️ Report is 236 commits behind head on master.

Files with missing lines Patch % Lines
...ain/java/io/dapr/testcontainers/DaprContainer.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1586      +/-   ##
============================================
+ Coverage     76.91%   78.49%   +1.57%     
- Complexity     1592     1935     +343     
============================================
  Files           145      216      +71     
  Lines          4843     5872    +1029     
  Branches        562      659      +97     
============================================
+ Hits           3725     4609     +884     
- Misses          821      926     +105     
- Partials        297      337      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add withAppProtocol to testcontainer

6 participants