-
Notifications
You must be signed in to change notification settings - Fork 223
Jobs promotion to DaprClient #1602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
69f7472 to
73e8c38
Compare
cicoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are compilation errors that need fixing from this PR - mind taking a look?
Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:testCompile (default-testCompile) on project dapr-sdk-tests: Compilation failure: Compilation failure:
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[101,22] cannot find symbol
Error: symbol: method scheduleJob(io.dapr.client.domain.ScheduleJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[104,26] cannot find symbol
Error: symbol: method getJob(io.dapr.client.domain.GetJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[106,22] cannot find symbol
Error: symbol: method deleteJob(io.dapr.client.domain.DeleteJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[118,22] cannot find symbol
Error: symbol: method scheduleJob(io.dapr.client.domain.ScheduleJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[122,26] cannot find symbol
Error: symbol: method getJob(io.dapr.client.domain.GetJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[124,22] cannot find symbol
Error: symbol: method deleteJob(io.dapr.client.domain.DeleteJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[139,22] cannot find symbol
Error: symbol: method scheduleJob(io.dapr.client.domain.ScheduleJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[147,26] cannot find symbol
Error: symbol: method getJob(io.dapr.client.domain.GetJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[149,22] cannot find symbol
Error: symbol: method deleteJob(io.dapr.client.domain.DeleteJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[168,22] cannot find symbol
Error: symbol: method scheduleJob(io.dapr.client.domain.ScheduleJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[176,26] cannot find symbol
Error: symbol: method getJob(io.dapr.client.domain.GetJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[178,22] cannot find symbol
Error: symbol: method deleteJob(io.dapr.client.domain.DeleteJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[191,22] cannot find symbol
Error: symbol: method scheduleJob(io.dapr.client.domain.ScheduleJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[200,26] cannot find symbol
Error: symbol: method getJob(io.dapr.client.domain.GetJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[202,22] cannot find symbol
Error: symbol: method deleteJob(io.dapr.client.domain.DeleteJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[217,22] cannot find symbol
Error: symbol: method scheduleJob(io.dapr.client.domain.ScheduleJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Error: /home/runner/work/java-sdk/java-sdk/sdk-tests/src/test/java/io/dapr/it/testcontainers/jobs/DaprJobsIT.java:[224,22] cannot find symbol
Error: symbol: method deleteJob(io.dapr.client.domain.DeleteJobRequest)
Error: location: variable daprPreviewClient of type io.dapr.client.DaprPreviewClient
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
09228a0 to
cfa0889
Compare
|
@cicoyle I was waiting for the pipelines to come back and show me those errors.. now that they run, fixes are pushed. Let's hope the pipelines behave now. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1602 +/- ##
============================================
+ Coverage 76.91% 78.65% +1.74%
- Complexity 1592 1958 +366
============================================
Files 145 217 +72
Lines 4843 5970 +1127
Branches 562 661 +99
============================================
+ Hits 3725 4696 +971
- Misses 821 934 +113
- Partials 297 340 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Promoted Jobs API to DaprClient. Updated example too.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1594
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: