fix flaky integration test ActorReminderRecoveryIT #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MregXN <mregxn@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #958 +/- ##
=========================================
Coverage 76.59% 76.59%
Complexity 1467 1467
=========================================
Files 137 137
Lines 4470 4470
Branches 526 526
=========================================
Hits 3424 3424
Misses 761 761
Partials 285 285 ☔ View full report in Codecov by Sentry. |
Contributor
|
LGTM 👍🏻 |
artursouza
approved these changes
Nov 20, 2023
Contributor
artursouza
left a comment
artursouza
left a comment
There was a problem hiding this comment.
Not my favorite fix, but sometimes it is needed.
addjuarez
pushed a commit
to addjuarez/java-sdk
that referenced
this pull request
Nov 27, 2023
Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com>
artursouza
added a commit
that referenced
this pull request
Feb 16, 2024
* Show registered workflow Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * Add `NewWorkflowOption` to config version, time, input, etc when start a new workflow (#945) * add NewWorkflowOption Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * fix style Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * add unit test Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * add more unit tests for improving coverage Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> --------- Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * Update CLI link in example readme's (#951) * Updated pre-requisite link to Dapr CLI Signed-off-by: Michaël Hompus <michael@hompus.nl> * Update JDK list to match all other examples Signed-off-by: Michaël Hompus <michael@hompus.nl> --------- Signed-off-by: Michaël Hompus <michael@hompus.nl> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * remove static Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * Add determinstic UUID generation (#947) * add determinstic UUID generation Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * add unit test to improve coverage Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> * update grpc version to 1.59.0 to be compatible updated durabletask-java Signed-off-by: kaibocai <kaibocai@microsoft.com> --------- Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Signed-off-by: kaibocai <kaibocai@microsoft.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * fix flaky integration test ActorExceptionIT (#954) Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * fix flaky it ActorReminderRecovery (#958) Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * fix flaky integration test MethodInvokeIT (#959) * fix flaky it MethodInvokeIT Signed-off-by: MregXN <mregxn@gmail.com> * add debug print Signed-off-by: MregXN <mregxn@gmail.com> * add debug print Signed-off-by: MregXN <mregxn@gmail.com> * add more waiting time Signed-off-by: MregXN <mregxn@gmail.com> * wait before invoke Signed-off-by: MregXN <mregxn@gmail.com> * wait for health before invoke Signed-off-by: MregXN <mregxn@gmail.com> --------- Signed-off-by: MregXN <mregxn@gmail.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * Fix errors Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> * make thead safe * Fix code and test. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Signed-off-by: Michaël Hompus <michael@hompus.nl> Signed-off-by: kaibocai <kaibocai@microsoft.com> Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Co-authored-by: Michaël Hompus <michael@hompus.nl> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: MregXN <46479059+MregXN@users.noreply.github.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: Artur Souza <asouza.pro@gmail.com>
artursouza
added a commit
that referenced
this pull request
Feb 19, 2024
* Show registered workflow * Add `NewWorkflowOption` to config version, time, input, etc when start a new workflow (#945) * add NewWorkflowOption * fix style * add unit test * add more unit tests for improving coverage --------- * Update CLI link in example readme's (#951) * Updated pre-requisite link to Dapr CLI * Update JDK list to match all other examples --------- * remove static * Add determinstic UUID generation (#947) * add determinstic UUID generation * add unit test to improve coverage * update grpc version to 1.59.0 to be compatible updated durabletask-java --------- * fix flaky integration test ActorExceptionIT (#954) * fix flaky it ActorReminderRecovery (#958) * fix flaky integration test MethodInvokeIT (#959) * fix flaky it MethodInvokeIT * add debug print * add debug print * add more waiting time * wait before invoke * wait for health before invoke --------- * Fix errors * make thead safe * Fix code and test. --------- Signed-off-by: addjuarez <6789375+addjuarez@users.noreply.github.com> Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Signed-off-by: Michaël Hompus <michael@hompus.nl> Signed-off-by: kaibocai <kaibocai@microsoft.com> Signed-off-by: MregXN <mregxn@gmail.com> Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: addjuarez <6789375+addjuarez@users.noreply.github.com> Co-authored-by: kaibocai <89094811+kaibocai@users.noreply.github.com> Co-authored-by: Michaël Hompus <michael@hompus.nl> Co-authored-by: MregXN <46479059+MregXN@users.noreply.github.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
it always fali due to rpc invoke connection refused. Pausing 3 seconds after set up is helpful for gRPC connection getting ready.
Issue reference
Please refer to the the point 4 of issue #7128 in dapr/dapr.