-
Notifications
You must be signed in to change notification settings - Fork 94
Fix test sequence and dev container #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
…'s a debug measurement Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
@shubham1172 can you review? |
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @XavierGeerinck, LGTM overall! Just had a few nits/questions.
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Note: awaiting merging, it seems that test-e2e is timing out (13min run time and counting so cancelling it and checking it)
|
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @XavierGeerinck, I only had a few minor comments from the last change.
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Since we are no more sending lint output to |
We can yes, there are quite some warning items. I will create one |
Signed-off-by: Xavier Geerinck xavier.geerinck@gmail.com
Description
Issue reference
Please reference the issue this PR will close: #177
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: