Resolve linter issues #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
|
@XavierGeerinck / @amulyavarote, should we enforce linting, going forward? |
shubham1172
commented
Feb 16, 2022
shubham1172
commented
Feb 16, 2022
shubham1172
commented
Feb 16, 2022
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
shubham1172
commented
Feb 16, 2022
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
|
/cc @XavierGeerinck for review |
|
LGTM |
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per #184, we stopped redirecting
npm run lintto/dev/null. This PR fixes some existing linting issues.Issue reference
Please reference the issue this PR will close: #188
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: