Skip to content

Conversation

@joebowbeer
Copy link
Contributor

@joebowbeer joebowbeer commented Aug 26, 2025

This was the testcontainer example from js-sdk

It builds and passes tests. Tests run via ts-jest; prepack runs the build script before pack or publish.

The output from npm pack or npm publish --dry-run is what I would expect (and hope for).

npm test
npm publish --dry-run

Still TODO:

  1. GitHub actions to publish/release
  2. Add to https://github.com/testcontainers/community-module-registry/blob/main/modules/dapr/index.md

@joebowbeer joebowbeer mentioned this pull request Aug 26, 2025
3 tasks
@joebowbeer joebowbeer force-pushed the testcontainer-1 branch 2 times, most recently from 7a6a881 to cd34dc7 Compare August 26, 2025 17:53
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
Copy link
Contributor

@WhitWaldo WhitWaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic - thank you for putting the Dapr copyright header on all the files and for generally putting together a solid implementation.

@WhitWaldo WhitWaldo merged commit 406c6c0 into dapr:main Sep 5, 2025
1 check passed
@joebowbeer joebowbeer deleted the testcontainer-1 branch September 5, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants