Skip to content

Started response guards prior to use default challenge and forbid calls #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2022
Merged

Started response guards prior to use default challenge and forbid calls #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ea1a87
adding guards for started response after AuthorizeAsync
Nov 18, 2022
514525f
adding guards for started response after AuthorizeAsync
Nov 18, 2022
eb81547
adding guards for started response after AuthorizeAsync
Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .build/release.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
<Authors>Arturo Martinez</Authors>
<Company>DarkLoop</Company>
<PackageId>DarkLoop.Azure.Functions.Authorize</PackageId>
<IsPreview>false</IsPreview>
<IsPreview>true</IsPreview>
<AssemblyVersion>3.0.0.0</AssemblyVersion>
<Version>3.1.1</Version>
<Version>3.1.2</Version>
<FileVersion>$(Version).0</FileVersion>
<RepositoryUrl>https://github.com/dark-loop/functions-authorize</RepositoryUrl>
<License>https://github.com/dark-loop/functions-authorize/blob/master/LICENSE</License>
Expand Down
42 changes: 24 additions & 18 deletions src/DarkLoop.Azure.Functions.Authorize/Security/FunctionsHttpAuthorizationHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,39 +36,45 @@ public async Task OnAuthorizingFunctionInstance(FunctionExecutingContext functio

if (context.Result is ChallengeResult challenge)
{
if (challenge.AuthenticationSchemes != null && challenge.AuthenticationSchemes.Count > 0)
if (!httpContext.Response.HasStarted)
{
foreach (var scheme in challenge.AuthenticationSchemes)
if (challenge.AuthenticationSchemes != null && challenge.AuthenticationSchemes.Count > 0)
{
await httpContext.ChallengeAsync(scheme);
foreach (var scheme in challenge.AuthenticationSchemes)
{
await httpContext.ChallengeAsync(scheme);
}
}
}
else
{
await httpContext.ChallengeAsync();
else
{
await httpContext.ChallengeAsync();
}

await SetResponseAsync("Unauthorized", httpContext.Response);
}

await SetResponseAsync("Unauthorized", httpContext.Response);

// need to make sure function stops executing. At this moment this is the only way.
BombFunctionInstance(HttpStatusCode.Unauthorized);
}

if (context.Result is ForbidResult forbid)
{
if (forbid.AuthenticationSchemes != null && forbid.AuthenticationSchemes.Count > 0)
if (!httpContext.Response.HasStarted)
{
foreach (var scheme in forbid.AuthenticationSchemes)
if (forbid.AuthenticationSchemes != null && forbid.AuthenticationSchemes.Count > 0)
{
await httpContext.ForbidAsync(scheme);
foreach (var scheme in forbid.AuthenticationSchemes)
{
await httpContext.ForbidAsync(scheme);
}
}
else
{
await httpContext.ForbidAsync();
}
}
else
{
await httpContext.ForbidAsync();
}

await SetResponseAsync("Forbidden", httpContext.Response);
await SetResponseAsync("Forbidden", httpContext.Response);
}

// need to make sure function stops executing. At this moment this is the only way.
BombFunctionInstance(HttpStatusCode.Forbidden);
Expand Down