Bug 1738106 - Part 3: Switch to TaskQueue::Create, r=xpcom-reviewers,necko-reviewers,media-playback-reviewers,dragana,alwu,barret

In future parts, TaskQueue will require extra initialization to be performed
which cannot happen in a constructor, as it takes references to the TaskQueue
object itself, which will require the introduction of a helper method. This
patch switches all callers of the TaskQueue constructor to use the new method.

Differential Revision: https://phabricator.services.mozilla.com/D142604

Author: mystor

dom/file/MutableBlobStorage.cpp

@@ -631,7 +631,7 @@ nsresult MutableBlobStorage::DispatchToIOThread(
         do_GetService(NS_STREAMTRANSPORTSERVICE_CONTRACTID);
     MOZ_ASSERT(target);
 
-    mTaskQueue = new TaskQueue(target.forget(), "BlobStorage");
+    mTaskQueue = TaskQueue::Create(target.forget(), "BlobStorage");
   }
 
   nsCOMPtr<nsIRunnable> runnable(aRunnable);

dom/indexedDB/ActorsChild.cpp

@@ -2662,7 +2662,7 @@ nsresult BackgroundRequestChild::PreprocessHelper::Init(
   // We use a TaskQueue here in order to be sure that the events are dispatched
   // in the correct order. This is not guaranteed in case we use the I/O thread
   // directly.
-  mTaskQueue = MakeRefPtr<TaskQueue>(target.forget(), "BackgroundRequestChild");
+  mTaskQueue = TaskQueue::Create(target.forget(), "BackgroundRequestChild");
 
   ErrorResult errorResult;
 

dom/media/Benchmark.cpp

@@ -126,8 +126,9 @@ bool VP9Benchmark::IsVP9DecodeFast(bool aDefault) {
 }
 
 Benchmark::Benchmark(MediaDataDemuxer* aDemuxer, const Parameters& aParameters)
-    : QueueObject(new TaskQueue(GetMediaThreadPool(MediaThreadType::SUPERVISOR),
-                                "Benchmark::QueueObject")),
+    : QueueObject(
+          TaskQueue::Create(GetMediaThreadPool(MediaThreadType::SUPERVISOR),
+                            "Benchmark::QueueObject")),
       mParameters(aParameters),
       mKeepAliveUntilComplete(this),
       mPlaybackState(this, aDemuxer) {
@@ -171,12 +172,13 @@ void Benchmark::Init() {
 
 BenchmarkPlayback::BenchmarkPlayback(Benchmark* aGlobalState,
                                      MediaDataDemuxer* aDemuxer)
-    : QueueObject(new TaskQueue(GetMediaThreadPool(MediaThreadType::SUPERVISOR),
-                                "BenchmarkPlayback::QueueObject")),
+    : QueueObject(
+          TaskQueue::Create(GetMediaThreadPool(MediaThreadType::SUPERVISOR),
+                            "BenchmarkPlayback::QueueObject")),
       mGlobalState(aGlobalState),
-      mDecoderTaskQueue(
-          new TaskQueue(GetMediaThreadPool(MediaThreadType::PLATFORM_DECODER),
-                        "BenchmarkPlayback::mDecoderTaskQueue")),
+      mDecoderTaskQueue(TaskQueue::Create(
+          GetMediaThreadPool(MediaThreadType::PLATFORM_DECODER),
+          "BenchmarkPlayback::mDecoderTaskQueue")),
       mDemuxer(aDemuxer),
       mSampleIndex(0),
       mFrameCount(0),

dom/media/MediaDecoderStateMachine.cpp

@@ -2761,9 +2761,9 @@ MediaDecoderStateMachine::MediaDecoderStateMachine(MediaDecoder* aDecoder,
       mAbstractMainThread(aDecoder->AbstractMainThread()),
       mFrameStats(&aDecoder->GetFrameStatistics()),
       mVideoFrameContainer(aDecoder->GetVideoFrameContainer()),
-      mTaskQueue(new TaskQueue(GetMediaThreadPool(MediaThreadType::MDSM),
-                               "MDSM::mTaskQueue",
-                               /* aSupportsTailDispatch = */ true)),
+      mTaskQueue(TaskQueue::Create(GetMediaThreadPool(MediaThreadType::MDSM),
+                                   "MDSM::mTaskQueue",
+                                   /* aSupportsTailDispatch = */ true)),
       mWatchManager(this, mTaskQueue),
       mDispatchedStateMachine(false),
       mDelayedScheduler(mTaskQueue, true /*aFuzzy*/),

dom/media/MediaFormatReader.cpp

@@ -501,9 +501,9 @@ class MediaFormatReader::DemuxerProxy {
 
  public:
   explicit DemuxerProxy(MediaDataDemuxer* aDemuxer)
-      : mTaskQueue(
-            new TaskQueue(GetMediaThreadPool(MediaThreadType::PLATFORM_DECODER),
-                          "DemuxerProxy::mTaskQueue")),
+      : mTaskQueue(TaskQueue::Create(
+            GetMediaThreadPool(MediaThreadType::PLATFORM_DECODER),
+            "DemuxerProxy::mTaskQueue")),
         mData(new Data(aDemuxer)) {
     MOZ_COUNT_CTOR(DemuxerProxy);
   }
@@ -853,9 +853,10 @@ MediaFormatReader::DemuxerProxy::NotifyDataArrived() {
 
 MediaFormatReader::MediaFormatReader(MediaFormatReaderInit& aInit,
                                      MediaDataDemuxer* aDemuxer)
-    : mTaskQueue(new TaskQueue(GetMediaThreadPool(MediaThreadType::SUPERVISOR),
-                               "MediaFormatReader::mTaskQueue",
-                               /* aSupportsTailDispatch = */ true)),
+    : mTaskQueue(
+          TaskQueue::Create(GetMediaThreadPool(MediaThreadType::SUPERVISOR),
+                            "MediaFormatReader::mTaskQueue",
+                            /* aSupportsTailDispatch = */ true)),
       mAudio(this, MediaData::Type::AUDIO_DATA,
              StaticPrefs::media_audio_max_decode_error()),
       mVideo(this, MediaData::Type::VIDEO_DATA,
@@ -998,12 +999,12 @@ nsresult MediaFormatReader::Init() {
   MOZ_ASSERT(NS_IsMainThread(), "Must be on main thread.");
 
   mAudio.mTaskQueue =
-      new TaskQueue(GetMediaThreadPool(MediaThreadType::PLATFORM_DECODER),
-                    "MFR::mAudio::mTaskQueue");
+      TaskQueue::Create(GetMediaThreadPool(MediaThreadType::PLATFORM_DECODER),
+                        "MFR::mAudio::mTaskQueue");
 
   mVideo.mTaskQueue =
-      new TaskQueue(GetMediaThreadPool(MediaThreadType::PLATFORM_DECODER),
-                    "MFR::mVideo::mTaskQueue");
+      TaskQueue::Create(GetMediaThreadPool(MediaThreadType::PLATFORM_DECODER),
+                        "MFR::mVideo::mTaskQueue");
 
   return NS_OK;
 }

dom/media/MediaManager.cpp

@@ -2060,7 +2060,7 @@ MediaManager* MediaManager::Get() {
     timesCreated++;
     MOZ_RELEASE_ASSERT(timesCreated == 1);
 
-    RefPtr<TaskQueue> mediaThread = new TaskQueue(
+    RefPtr<TaskQueue> mediaThread = TaskQueue::Create(
         GetMediaThreadPool(MediaThreadType::SUPERVISOR), "MediaManager");
     LOG("New Media thread for gum");
 

dom/media/MediaRecorder.cpp

@@ -822,7 +822,7 @@ class MediaRecorder::Session : public PrincipalChangeObserver<MediaStreamTrack>,
     }
 
     mEncoderThread =
-        MakeAndAddRef<TaskQueue>(pool.forget(), "MediaRecorderReadThread");
+        TaskQueue::Create(pool.forget(), "MediaRecorderReadThread");
 
     MOZ_DIAGNOSTIC_ASSERT(!mShutdownBlocker);
     // Add a shutdown blocker so mEncoderThread can be shutdown async.

dom/media/VideoFrameConverter.h

@@ -47,7 +47,7 @@ class VideoFrameConverter {
   explicit VideoFrameConverter(
       const dom::RTCStatsTimestampMaker& aTimestampMaker)
       : mTimestampMaker(aTimestampMaker),
-        mTaskQueue(MakeAndAddRef<TaskQueue>(
+        mTaskQueue(TaskQueue::Create(
             GetMediaThreadPool(MediaThreadType::WEBRTC_WORKER),
             "VideoFrameConverter")),
         mPacer(MakeAndAddRef<Pacer<FrameToProcess>>(

dom/media/VideoUtils.cpp

@@ -778,7 +778,7 @@ nsresult GenerateRandomPathName(nsCString& aOutSalt, uint32_t aLength) {
 }
 
 already_AddRefed<TaskQueue> CreateMediaDecodeTaskQueue(const char* aName) {
-  RefPtr<TaskQueue> queue = new TaskQueue(
+  RefPtr<TaskQueue> queue = TaskQueue::Create(
       GetMediaThreadPool(MediaThreadType::PLATFORM_DECODER), aName);
   return queue.forget();
 }

dom/media/gtest/TestMP4Demuxer.cpp

@@ -41,7 +41,7 @@ class MP4DemuxerBinding {
   explicit MP4DemuxerBinding(const char* aFileName = "dash_dashinit.mp4")
       : resource(new MockMediaResource(aFileName)),
         mDemuxer(new MP4Demuxer(resource)),
-        mTaskQueue(new TaskQueue(
+        mTaskQueue(TaskQueue::Create(
             GetMediaThreadPool(MediaThreadType::SUPERVISOR), "TestMP4Demuxer")),
         mIndex(0) {
     EXPECT_EQ(NS_OK, resource->Open());