Bug 1445302 - Replace TArray.RemoveElementAt(TArray.Length() - 1) pattern with TArray.RemoveLastElement() or TArray.PopLastElement() r=froydnj

MozReview-Commit-ID: rGjabnP2iz

--HG--
extra : rebase_source : 1ef6c5ce028ac9ebd9f3176d57835c43fe46bada

Author: mikokm

accessible/base/TreeWalker.cpp

@@ -345,7 +345,6 @@ TreeWalker::AccessibleFor(nsIContent* aNode, uint32_t aFlags, bool* aSkipSubtree
 dom::AllChildrenIterator*
 TreeWalker::PopState()
 {
-  size_t length = mStateStack.Length();
-  mStateStack.RemoveElementAt(length - 1);
+  mStateStack.RemoveLastElement();
   return mStateStack.IsEmpty() ? nullptr : &mStateStack.LastElement();
 }

dom/animation/KeyframeUtils.cpp

@@ -1188,7 +1188,7 @@ HandleMissingFinalKeyframe(nsTArray<AnimationProperty>& aResult,
     // If we have already appended a new entry for the property so we have to
     // remove it.
     if (aCurrentAnimationProperty) {
-      aResult.RemoveElementAt(aResult.Length() - 1);
+      aResult.RemoveLastElement();
     }
     return;
   }

dom/base/TimeoutManager.cpp

@@ -156,7 +156,7 @@ TimeoutManager::DestroyFiringId(uint32_t aFiringId)
 {
   MOZ_DIAGNOSTIC_ASSERT(!mFiringIdStack.IsEmpty());
   MOZ_DIAGNOSTIC_ASSERT(mFiringIdStack.LastElement() == aFiringId);
-  mFiringIdStack.RemoveElementAt(mFiringIdStack.Length() - 1);
+  mFiringIdStack.RemoveLastElement();
 }
 
 bool

dom/base/nsDocumentEncoder.cpp

@@ -823,7 +823,7 @@ nsDocumentEncoder::SerializeRangeContextEnd(nsAString& aString)
       break;
   }
 
-  mRangeContexts.RemoveElementAt(mRangeContexts.Length() - 1);
+  mRangeContexts.RemoveLastElement();
   return rv;
 }
 

dom/base/nsFrameMessageManager.cpp

@@ -1105,7 +1105,7 @@ nsFrameMessageManager::ReceiveMessage(nsISupports* aTarget,
           StructuredCloneData* data = aRetVal->AppendElement();
           data->Write(cx, rval, rv);
           if (NS_WARN_IF(rv.Failed())) {
-            aRetVal->RemoveElementAt(aRetVal->Length() - 1);
+            aRetVal->RemoveLastElement();
             nsString msg = aMessage + NS_LITERAL_STRING(": message reply cannot be cloned. Are you trying to send an XPCOM object?");
 
             nsCOMPtr<nsIConsoleService> console(do_GetService(NS_CONSOLESERVICE_CONTRACTID));

dom/base/nsHTMLContentSerializer.cpp

@@ -328,7 +328,7 @@ nsHTMLContentSerializer::AppendElementEnd(Element* aElement, nsAString& aStr)
     /* Though at this point we must always have an state to be deleted as all
     the OL opening tags are supposed to push an olState object to the stack*/
     if (!mOLStateStack.IsEmpty()) {
-      mOLStateStack.RemoveElementAt(mOLStateStack.Length() -1);
+      mOLStateStack.RemoveLastElement();
     }
   }
 

dom/base/nsXHTMLContentSerializer.cpp

@@ -455,7 +455,7 @@ nsXHTMLContentSerializer::CheckElementEnd(mozilla::dom::Element* aElement,
     /* Though at this point we must always have an state to be deleted as all
        the OL opening tags are supposed to push an olState object to the stack*/
     if (!mOLStateStack.IsEmpty()) {
-        mOLStateStack.RemoveElementAt(mOLStateStack.Length() -1);
+      mOLStateStack.RemoveLastElement();
     }
   }
 

dom/canvas/CanvasRenderingContext2D.cpp

@@ -2240,7 +2240,7 @@ CanvasRenderingContext2D::Restore()
     }
   }
 
-  mStyleStack.RemoveElementAt(mStyleStack.Length() - 1);
+  mStyleStack.RemoveLastElement();
 
   mTarget->SetTransform(CurrentState().transform);
 }

dom/media/webrtc/MediaTrackConstraints.cpp

@@ -531,7 +531,7 @@ MediaConstraintsHelper::SelectSettings(
     }
     if (aDevices.IsEmpty()) {
       aDevices.AppendElements(Move(rejects));
-      aggregateConstraints.RemoveElementAt(aggregateConstraints.Length() - 1);
+      aggregateConstraints.RemoveLastElement();
     }
   }
   return nullptr;

dom/workers/WorkerLoadInfo.cpp

@@ -529,7 +529,7 @@ InterfaceRequestor::GetAnyLiveTabChild()
     }
 
     // Otherwise remove the stale weak reference and check the next one
-    mTabChildList.RemoveElementAt(mTabChildList.Length() - 1);
+    mTabChildList.RemoveLastElement();
   }
 
   return nullptr;