Bug 1270746 part 5 - Remove hasInstance class hook. r=iain

Code should use `Symbol.hasInstance` to customize `instanceof` behavior.

Differential Revision: https://phabricator.services.mozilla.com/D141346

Author: jandem

dom/bindings/BindingUtils.cpp

@@ -2107,7 +2107,6 @@ const JSClassOps sBoringInterfaceObjectClassClassOps = {
     nullptr,             /* mayResolve */
     nullptr,             /* finalize */
     ThrowingConstructor, /* call */
-    nullptr,             /* hasInstance */
     ThrowingConstructor, /* construct */
     nullptr,             /* trace */
 };

dom/bindings/Codegen.py

@@ -690,7 +690,6 @@ def define(self):
               ${mayResolve}, /* mayResolve */
               ${finalize}, /* finalize */
               ${call}, /* call */
-              nullptr,               /* hasInstance */
               nullptr,               /* construct */
               ${trace}, /* trace */
             };
@@ -976,7 +975,6 @@ def define(self):
                     nullptr,               /* mayResolve */
                     nullptr,               /* finalize */
                     ${ctorname}, /* call */
-                    nullptr,               /* hasInstance */
                     ${ctorname}, /* construct */
                     nullptr,               /* trace */
                 };

dom/bindings/SimpleGlobalObject.cpp

@@ -69,7 +69,6 @@ static const JSClassOps SimpleGlobalClassOps = {
     SimpleGlobal_finalize,
     nullptr,
     nullptr,
-    nullptr,
     JS_GlobalObjectTraceHook,
 };
 

js/public/Class.h

@@ -297,14 +297,6 @@ typedef bool (*JSMayResolveOp)(const JSAtomState& names, jsid id,
  */
 typedef void (*JSFinalizeOp)(JS::GCContext* gcx, JSObject* obj);
 
-/**
- * Check whether v is an instance of obj.  Return false on error or exception,
- * true on success with true in *bp if v is an instance of obj, false in
- * *bp otherwise.
- */
-typedef bool (*JSHasInstanceOp)(JSContext* cx, JS::HandleObject obj,
-                                JS::MutableHandleValue vp, bool* bp);
-
 /**
  * Function type for trace operation of the class called to enumerate all
  * traceable things reachable from obj's private data structure. For each such
@@ -608,7 +600,6 @@ struct MOZ_STATIC_CLASS JSClassOps {
   JSMayResolveOp mayResolve;
   JSFinalizeOp finalize;
   JSNative call;
-  JSHasInstanceOp hasInstance;
   JSNative construct;
   JSTraceOp trace;
 };
@@ -643,9 +634,6 @@ struct alignas(js::gc::JSClassAlignBytes) JSClass {
     return cOps ? cOps->mayResolve : nullptr;
   }
   JSNative getCall() const { return cOps ? cOps->call : nullptr; }
-  JSHasInstanceOp getHasInstance() const {
-    return cOps ? cOps->hasInstance : nullptr;
-  }
   JSNative getConstruct() const { return cOps ? cOps->construct : nullptr; }
 
   bool hasFinalize() const { return cOps && cOps->finalize; }

js/src/builtin/Array.cpp

@@ -4594,7 +4594,6 @@ static const JSClassOps ArrayObjectClassOps = {
     nullptr,            // mayResolve
     nullptr,            // finalize
     nullptr,            // call
-    nullptr,            // hasInstance
     nullptr,            // construct
     nullptr,            // trace
 };

js/src/builtin/DataViewObject.cpp

@@ -945,7 +945,6 @@ static const JSClassOps DataViewObjectClassOps = {
     nullptr,                       // mayResolve
     nullptr,                       // finalize
     nullptr,                       // call
-    nullptr,                       // hasInstance
     nullptr,                       // construct
     ArrayBufferViewObject::trace,  // trace
 };

js/src/builtin/FinalizationRegistryObject.cpp

@@ -98,7 +98,6 @@ const JSClassOps FinalizationRegistrationsObject::classOps_ = {
     nullptr,                                    // mayResolve
     FinalizationRegistrationsObject::finalize,  // finalize
     nullptr,                                    // call
-    nullptr,                                    // hasInstance
     nullptr,                                    // construct
     FinalizationRegistrationsObject::trace,     // trace
 };
@@ -211,7 +210,6 @@ const JSClassOps FinalizationRegistryObject::classOps_ = {
     nullptr,                               // mayResolve
     FinalizationRegistryObject::finalize,  // finalize
     nullptr,                               // call
-    nullptr,                               // hasInstance
     nullptr,                               // construct
     FinalizationRegistryObject::trace,     // trace
 };
@@ -651,7 +649,6 @@ const JSClassOps FinalizationQueueObject::classOps_ = {
     nullptr,                            // mayResolve
     FinalizationQueueObject::finalize,  // finalize
     nullptr,                            // call
-    nullptr,                            // hasInstance
     nullptr,                            // construct
     FinalizationQueueObject::trace,     // trace
 };

js/src/builtin/MapObject.cpp

@@ -193,7 +193,6 @@ static const JSClassOps MapIteratorObjectClassOps = {
     nullptr,                      // mayResolve
     MapIteratorObject::finalize,  // finalize
     nullptr,                      // call
-    nullptr,                      // hasInstance
     nullptr,                      // construct
     nullptr,                      // trace
 };
@@ -433,7 +432,6 @@ const JSClassOps MapObject::classOps_ = {
     nullptr,   // mayResolve
     finalize,  // finalize
     nullptr,   // call
-    nullptr,   // hasInstance
     nullptr,   // construct
     trace,     // trace
 };
@@ -1007,7 +1005,6 @@ static const JSClassOps SetIteratorObjectClassOps = {
     nullptr,                      // mayResolve
     SetIteratorObject::finalize,  // finalize
     nullptr,                      // call
-    nullptr,                      // hasInstance
     nullptr,                      // construct
     nullptr,                      // trace
 };
@@ -1215,7 +1212,6 @@ const JSClassOps SetObject::classOps_ = {
     nullptr,   // mayResolve
     finalize,  // finalize
     nullptr,   // call
-    nullptr,   // hasInstance
     nullptr,   // construct
     trace,     // trace
 };

js/src/builtin/ModuleObject.cpp

@@ -775,7 +775,6 @@ void ModuleNamespaceObject::ProxyHandler::finalize(JS::GCContext* gcx,
     nullptr,                 // mayResolve
     ModuleObject::finalize,  // finalize
     nullptr,                 // call
-    nullptr,                 // hasInstance
     nullptr,                 // construct
     ModuleObject::trace,     // trace
 };

js/src/builtin/RecordObject.cpp

@@ -68,7 +68,6 @@ static const JSClassOps RecordObjectClassOps = {
     nullptr,      // mayResolve
     nullptr,      // finalize
     nullptr,      // call
-    nullptr,      // hasInstance
     nullptr,      // construct
     nullptr,      // trace
 };