Skip to content

Commit a3fd09c

Browse files
committed
Bug 1799131 - Adjust test-info manifests to retain ancestor. r=gbrown,asuth
Differential Revision: https://phabricator.services.mozilla.com/D161271
1 parent deaf08c commit a3fd09c

File tree

1 file changed

+21
-5
lines changed

1 file changed

+21
-5
lines changed

testing/testinfo.py

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -484,8 +484,11 @@ def matches_filters(test):
484484

485485
manifest_paths = set()
486486
for t in tests:
487-
if "manifest" in t and t["manifest"] is not None:
488-
manifest_paths.add(t["manifest"])
487+
if t.get("manifest", None):
488+
manifest_path = t["manifest"]
489+
if t.get("ancestor_manifest", None):
490+
manifest_path = "%s:%s" % (t["ancestor_manifest"], t["manifest"])
491+
manifest_paths.add(manifest_path)
489492
manifest_count = len(manifest_paths)
490493
print(
491494
"Resolver found {} tests, {} manifests".format(len(tests), manifest_count)
@@ -637,6 +640,13 @@ def matches_filters(test):
637640
else:
638641
test_info["manifest"] = [t["manifest_relpath"]]
639642

643+
# handle included manifests as ancestor:child
644+
if t.get("ancestor_manifest", None):
645+
test_info["manifest"] = [
646+
"%s:%s"
647+
% (t["ancestor_manifest"], test_info["manifest"][0])
648+
]
649+
640650
if show_tests:
641651
rkey = key if show_components else "all"
642652
if rkey in by_component["tests"]:
@@ -656,9 +666,15 @@ def matches_filters(test):
656666
test_info["manifest"][0]
657667
not in ti["manifest"]
658668
):
659-
ti["manifest"].extend(
660-
test_info["manifest"]
661-
)
669+
ti_manifest = test_info["manifest"]
670+
if test_info.get(
671+
"ancestor_manifest", None
672+
):
673+
ti_manifest = "%s:%s" % (
674+
test_info["ancestor_manifest"],
675+
ti_manifest,
676+
)
677+
ti["manifest"].extend(ti_manifest)
662678
else:
663679
by_component["tests"][rkey] = [test_info]
664680
if show_tests:

0 commit comments

Comments
 (0)