Skip to content

Commit bc9290f

Browse files
Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan
The inclusions were removed with the following very crude script and the resulting breakage was fixed up by hand. The manual fixups did either revert the changes done by the script, replace a generic header with a more specific one or replace a header with a forward declaration. find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2) if [ -n "$interfaces" ]; then if [[ "$interfaces" == *$'\n'* ]]; then regexp="\(" for i in $interfaces; do regexp="$regexp$i\|"; done regexp="${regexp%%\\\|}\)" else regexp="$interfaces" fi interface=$(basename "$path") rg -l "#include.*${interface%%.idl}.h" . | while read path2; do hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" ) if [ $hits -eq 0 ]; then echo "Removing ${interface} from ${path2}" grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp mv -f "$path2".tmp "$path2" fi done fi done Differential Revision: https://phabricator.services.mozilla.com/D55442 --HG-- extra : moz-landing-system : lando
1 parent 4be2734 commit bc9290f

File tree

391 files changed

+38
-826
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

391 files changed

+38
-826
lines changed

dom/animation/KeyframeEffect.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
#include "nsCSSPseudoElements.h" // For PseudoStyleType
3737
#include "nsDOMMutationObserver.h" // For nsAutoAnimationMutationBatch
3838
#include "nsIFrame.h"
39-
#include "nsIScriptError.h"
4039
#include "nsPresContextInlines.h"
4140
#include "nsRefreshDriver.h"
4241

dom/audiochannel/AudioChannelAgent.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
#include "nsContentUtils.h"
99
#include "mozilla/dom/Document.h"
1010
#include "nsPIDOMWindow.h"
11-
#include "nsIURI.h"
1211

1312
using namespace mozilla::dom;
1413

dom/audiochannel/AudioChannelService.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
#include "mozilla/Unused.h"
1414

1515
#include "nsContentUtils.h"
16-
#include "nsIScriptSecurityManager.h"
1716
#include "nsISupportsPrimitives.h"
1817
#include "nsThreadUtils.h"
1918
#include "nsHashPropertyBag.h"

dom/base/BarProps.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
#include "mozilla/dom/BarPropBinding.h"
99
#include "nsContentUtils.h"
1010
#include "nsGlobalWindow.h"
11-
#include "nsIDocShell.h"
1211
#include "nsIScrollable.h"
1312
#include "nsIWebBrowserChrome.h"
1413

dom/base/CharacterData.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#include "mozilla/dom/Document.h"
2424
#include "nsReadableUtils.h"
2525
#include "mozilla/InternalMutationEvent.h"
26-
#include "nsIURI.h"
2726
#include "nsCOMPtr.h"
2827
#include "nsDOMString.h"
2928
#include "nsChangeHint.h"

dom/base/ContentProcessMessageManager.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
#include "nsFrameMessageManager.h"
1414
#include "nsIScriptContext.h"
1515
#include "nsIScriptContext.h"
16-
#include "nsIClassInfo.h"
17-
#include "nsIRunnable.h"
1816
#include "nsServiceManagerUtils.h"
1917
#include "nsWeakReference.h"
2018
#include "nsWrapperCache.h"

dom/base/DOMParser.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
#include "SystemPrincipal.h"
1313
#include "nsIStreamListener.h"
1414
#include "nsStringStream.h"
15-
#include "nsIScriptError.h"
16-
#include "nsIScriptSecurityManager.h"
1715
#include "nsCRT.h"
1816
#include "nsStreamUtils.h"
1917
#include "nsContentUtils.h"

dom/base/DispatcherTrait.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
#include "mozilla/AbstractThread.h"
1010
#include "mozilla/SchedulerGroup.h"
11-
#include "nsINamed.h"
1211

1312
using namespace mozilla;
1413
using namespace mozilla::dom;

dom/base/DocGroup.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#include "mozilla/ThrottledEventQueue.h"
1313
#include "mozilla/StaticPrefs_dom.h"
1414
#include "mozilla/Telemetry.h"
15-
#include "nsIDocShell.h"
1615
#include "nsDOMMutationObserver.h"
1716
#include "nsProxyRelease.h"
1817
#if defined(XP_WIN)

dom/base/Document.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@
138138
#include "mozilla/dom/PromiseNativeHandler.h"
139139
#include "mozilla/dom/TreeWalker.h"
140140

141-
#include "nsIServiceManager.h"
142141
#include "mozilla/dom/ServiceWorkerManager.h"
143142
#include "imgLoader.h"
144143

@@ -176,7 +175,6 @@
176175

177176
#include "nsPIDOMWindow.h"
178177
#include "nsFocusManager.h"
179-
#include "nsICookiePermission.h"
180178
#include "nsICookieService.h"
181179

182180
#include "nsBidiUtils.h"
@@ -198,7 +196,6 @@
198196
#include "nsDOMCID.h"
199197

200198
#include "jsapi.h"
201-
#include "nsIXPConnect.h"
202199
#include "xpcpublic.h"
203200
#include "nsCCUncollectableMarker.h"
204201
#include "nsIContentPolicy.h"
@@ -256,7 +253,6 @@
256253

257254
#include "mozilla/Preferences.h"
258255

259-
#include "imgILoader.h"
260256
#include "imgRequestProxy.h"
261257
#include "nsWrapperCacheInlines.h"
262258
#include "nsSandboxFlags.h"
@@ -295,12 +291,10 @@
295291
#include "nsIDocumentEncoder.h"
296292
#include "nsIDocumentActivity.h"
297293
#include "nsIStructuredCloneContainer.h"
298-
#include "nsIMutableArray.h"
299294
#include "mozilla/dom/DOMStringList.h"
300295
#include "nsWindowSizes.h"
301296
#include "mozilla/dom/Location.h"
302297
#include "mozilla/dom/FontFaceSet.h"
303-
#include "nsISupportsPrimitives.h"
304298
#include "mozilla/ServoStyleSet.h"
305299
#include "mozilla/StyleSheet.h"
306300
#include "mozilla/StyleSheetInlines.h"

0 commit comments

Comments
 (0)