Skip to content

Commit bdd5140

Browse files
committed
Backed out changeset fee2a1521dfe (bug 1769098) for causing python failures. CLOSED TREE
1 parent 8cfdac9 commit bdd5140

File tree

6 files changed

+5
-32
lines changed

6 files changed

+5
-32
lines changed

build/gen_test_packages_manifest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ def generate_package_data(args):
114114
if pkg_name is None:
115115
continue
116116
harness_requirements[harness].append(pkg_name)
117-
harness_requirements[harness].append("target.condprof.tests.tar.gz")
118117
return harness_requirements
119118

120119

taskcluster/gecko_taskgraph/test/test_util_chunking.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ def inner(
159159
"headless": headless,
160160
"tsan": tsan,
161161
"appname": "firefox",
162-
"condprof": False,
163162
}
164163

165164
return inner

taskcluster/gecko_taskgraph/util/chunking.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
from abc import ABCMeta, abstractmethod
1212

1313
from manifestparser import TestManifest
14-
from manifestparser.filters import chunk_by_runtime, tags
14+
from manifestparser.filters import chunk_by_runtime
1515
from mozbuild.util import memoize
1616
from moztest.resolve import (
1717
TEST_SUITES,
@@ -56,7 +56,6 @@ def guess_mozinfo_from_task(task):
5656
for key in setting["runtime"].keys()
5757
),
5858
"headless": "-headless" in task["test-name"],
59-
"condprof": "conditioned_profile" in setting["runtime"].keys(),
6059
"tsan": setting["build"].get("tsan", False),
6160
"xorigin": any("xorigin" in key for key in setting["runtime"].keys()),
6261
"socketprocess_networking": "socketprocess_networking"
@@ -228,14 +227,10 @@ def get_manifests(self, suite, mozinfo):
228227

229228
manifests = {chunk_by_runtime.get_manifest(t) for t in tests}
230229

231-
filters = None
232-
if mozinfo["condprof"]:
233-
filters = [tags(["condprof"])]
234-
235230
# Compute the active tests.
236231
m = TestManifest()
237232
m.tests = tests
238-
tests = m.active_tests(disabled=False, exists=False, filters=filters, **mozinfo)
233+
tests = m.active_tests(disabled=False, exists=False, **mozinfo)
239234
active = {chunk_by_runtime.get_manifest(t) for t in tests}
240235
skipped = manifests - active
241236
return {"active": list(active), "skipped": list(skipped)}

testing/condprofile/condprof/client.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929
TC_SERVICE = "https://firefox-ci-tc.services.mozilla.com"
3030
ROOT_URL = TC_SERVICE + "/api/index"
31-
INDEX_PATH = "gecko.v2.%(repo)s.latest.firefox.condprof-%(platform)s-%(scenario)s"
31+
INDEX_PATH = "gecko.v2.%(repo)s.latest.firefox.condprof-%(platform)s"
3232
PUBLIC_DIR = "artifacts/public/condprof"
3333
TC_LINK = ROOT_URL + "/v1/task/" + INDEX_PATH + "/" + PUBLIC_DIR + "/"
3434
ARTIFACT_NAME = "profile-%(platform)s-%(scenario)s-%(customization)s.tgz"
@@ -135,7 +135,6 @@ def get_profile(
135135
If task_id is provided, will grab the profile from that task. when not
136136
provided (default) will grab the latest profile.
137137
"""
138-
139138
# XXX assert values
140139
params = {
141140
"platform": platform,
@@ -213,8 +212,8 @@ def onerror(error):
213212
raise ProfileNotFoundError(url)
214213

215214

216-
def read_changelog(platform, repo="mozilla-central", scenario="settled"):
217-
params = {"platform": platform, "repo": repo, "scenario": scenario}
215+
def read_changelog(platform, repo="mozilla-central"):
216+
params = {"platform": platform, "repo": repo}
218217
changelog_url = CHANGELOG_LINK % params
219218
logger.info("Getting %s" % changelog_url)
220219
download_dir = tempfile.mkdtemp()

testing/config/mozbase_requirements.txt

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,3 @@
2121
../mozbase/mozscreenshot
2222
../mozbase/moztest
2323
../mozbase/mozversion
24-
25-
../condprofile
26-
aiohttp==3.7.4.post0
27-
https://pypi.pub.build.mozilla.org/pub/arsenic-19.1-py3-none-any.whl
28-
requests==2.22.0
29-
pyyaml==5.1.2
30-
structlog==15.2.0

testing/mozharness/scripts/desktop_unittest.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -305,15 +305,6 @@ class DesktopUnittest(TestingMixin, MercurialScript, MozbaseMixin, CodeCoverageM
305305
"help": "do not run tests with fission enabled.",
306306
},
307307
],
308-
[
309-
["--conditioned-profile"],
310-
{
311-
"action": "store_true",
312-
"default": False,
313-
"dest": "conditioned_profile",
314-
"help": "run tests with a conditioned profile",
315-
},
316-
],
317308
]
318309
+ copy.deepcopy(testing_config_options)
319310
+ copy.deepcopy(code_coverage_config_options)
@@ -654,9 +645,6 @@ def _query_abs_base_cmd(self, suite_category, suite):
654645
if c["crash_as_pass"]:
655646
base_cmd.append("--crash-as-pass")
656647

657-
if c["conditioned_profile"]:
658-
base_cmd.append("--conditioned-profile")
659-
660648
# set pluginsPath
661649
abs_res_plugins_dir = os.path.join(abs_res_dir, "plugins")
662650
str_format_values["test_plugin_path"] = abs_res_plugins_dir

0 commit comments

Comments
 (0)