Backed out 11 changesets (bug 1359269) for Linting failure. CLOSED TREE

Backed out changeset 00461a29f650 (bug 1359269)
Backed out changeset 6c09eccc4bd1 (bug 1359269)
Backed out changeset ae30401e7988 (bug 1359269)
Backed out changeset 8f9509e82439 (bug 1359269)
Backed out changeset bfb153c7f9c3 (bug 1359269)
Backed out changeset 1430913c5e9e (bug 1359269)
Backed out changeset 4bb00dc53459 (bug 1359269)
Backed out changeset 7705b1ebb154 (bug 1359269)
Backed out changeset 7fd8a3c1f827 (bug 1359269)
Backed out changeset c3f37539cb31 (bug 1359269)
Backed out changeset bb694b612b1b (bug 1359269)

Author: dgluca

dom/bindings/Bindings.conf

@@ -1828,11 +1828,6 @@ DOMInterfaces = {
         'headerFile': 'TestBindingHeader.h',
         'register': False,
         },
-
-'TestAttributesOnTypes' : {
-        'headerFile': 'TestBindingHeader.h',
-        'register': False,
-        },
 }
 
 # These are temporary, until they've been converted to use new DOM bindings

dom/bindings/Codegen.py

@@ -4570,6 +4570,9 @@ def getJSToNativeConversionInfo(type, descriptorProvider, failureCode=None,
                                 isOptional=False,
                                 invalidEnumValueFatal=True,
                                 defaultValue=None,
+                                treatNullAs="Default",
+                                isEnforceRange=False,
+                                isClamp=False,
                                 isNullOrUndefined=False,
                                 exceptionCode=None,
                                 lenientFloatCode=None,
@@ -4647,9 +4650,6 @@ def getJSToNativeConversionInfo(type, descriptorProvider, failureCode=None,
     # And we can't both be an object and be null or undefined
     assert not isDefinitelyObject or not isNullOrUndefined
 
-    isClamp = type.clamp
-    isEnforceRange = type.enforceRange
-
     # If exceptionCode is not set, we'll just rethrow the exception we got.
     # Note that we can't just set failureCode to exceptionCode, because setting
     # failureCode will prevent pending exceptions from being set in cases when
@@ -5788,10 +5788,6 @@ def handleNull(templateBody, setToNullVar, extraConditionForNull=""):
             undefinedBehavior = "eNull"
         else:
             undefinedBehavior = "eStringify"
-            if type.treatNullAsEmpty:
-                treatNullAs = "EmptyString"
-            else:
-                treatNullAs = "Default"
         nullBehavior = treatAs[treatNullAs]
 
         def getConversionCode(varName):
@@ -6447,6 +6443,9 @@ def define(self):
                         not self.argument.variadic),
             invalidEnumValueFatal=self.invalidEnumValueFatal,
             defaultValue=self.argument.defaultValue,
+            treatNullAs=self.argument.treatNullAs,
+            isEnforceRange=self.argument.enforceRange,
+            isClamp=self.argument.clamp,
             lenientFloatCode=self.lenientFloatCode,
             isMember="Variadic" if self.argument.variadic else False,
             allowTreatNonCallableAsNull=self.argument.allowTreatNonCallableAsNull(),
@@ -8612,6 +8611,18 @@ def __init__(self, type, interfaceMember, name="arg", allowTreatNonCallableAsNul
         self.variadic = False
         self.defaultValue = None
         self._allowTreatNonCallableAsNull = allowTreatNonCallableAsNull
+        # For FakeArguments generated by maplike/setlike convenience functions,
+        # we won't have an interfaceMember to pass in.
+        if interfaceMember:
+            self.treatNullAs = interfaceMember.treatNullAs
+        else:
+            self.treatNullAs = "Default"
+        if isinstance(interfaceMember, IDLAttribute):
+            self.enforceRange = interfaceMember.enforceRange
+            self.clamp = interfaceMember.clamp
+        else:
+            self.enforceRange = False
+            self.clamp = False
 
         self.identifier = FakeIdentifier(name)
 
@@ -11313,6 +11324,7 @@ def __init__(self, descriptor, operation, checkFound=True,
             argument = arguments[1]
             info = getJSToNativeConversionInfo(
                 argument.type, descriptor,
+                treatNullAs=argument.treatNullAs,
                 sourceDescription=("value being assigned to %s setter" %
                                    descriptor.interface.identifier.name))
             if argumentHandleValue is None:
@@ -13311,6 +13323,8 @@ def __init__(self, dictionary, descriptorProvider):
              getJSToNativeConversionInfo(
                  member.type,
                  descriptorProvider,
+                 isEnforceRange=member.enforceRange,
+                 isClamp=member.clamp,
                  isMember="Dictionary",
                  isOptional=member.canHaveMissingValue(),
                  defaultValue=member.defaultValue,
@@ -16360,6 +16374,7 @@ def __init__(self, descriptor, spiderMonkeyInterfacesAreStructs=False):
 
 class FakeMember():
     def __init__(self, name=None):
+        self.treatNullAs = "Default"
         if name is not None:
             self.identifier = FakeIdentifier(name)
 

dom/bindings/GenerateCSS2PropertiesWebIDL.py

@@ -11,7 +11,7 @@
 # (whether camelCase, _underscorePrefixed, etc.) and the given array of
 # extended attributes.
 def generateLine(propName, extendedAttrs):
-    return "  [%s] attribute [TreatNullAs=EmptyString] DOMString %s;\n" % (", ".join(extendedAttrs),
+    return "  [%s] attribute DOMString %s;\n" % (", ".join(extendedAttrs),
                                                  propName)
 def generate(output, idlFilename, dataFile):
     propList = runpy.run_path(dataFile)["data"]
@@ -21,7 +21,7 @@ def generate(output, idlFilename, dataFile):
             continue
         # Unfortunately, even some of the getters here are fallible
         # (e.g. on nsComputedDOMStyle).
-        extendedAttrs = ["CEReactions", "Throws",
+        extendedAttrs = ["CEReactions", "Throws", "TreatNullAs=EmptyString",
                          "SetterNeedsSubjectPrincipal=NonSystem"]
         if p.pref is not "":
             extendedAttrs.append('Pref="%s"' % p.pref)