Backed out changeset a653a439a39b (bug 1483905)for build bustages on webauthn/WebAuthnTransactionChild.cpp:35 CLOSED TREE

Author: aiakab

dom/webauthn/WebAuthnTransactionChild.cpp

@@ -28,11 +28,6 @@ WebAuthnTransactionChild::RecvConfirmRegister(const uint64_t& aTransactionId,
     return IPC_FAIL_NO_REASON(this);
   }
 
-  // We don't own the reference to mManager. We need to prevent its refcount
-  // going to 0 while we call anything that can reach the call to
-  // StopListeningForVisibilityEvents in WebAuthnManager::ClearTransaction
-  // (often via WebAuthnManager::RejectTransaction).
-  RefPtr<WebAuthnManagerBase> kungFuDeathGrip(mManager);
   mManager->FinishMakeCredential(aTransactionId, aResult);
   return IPC_OK();
 }
@@ -45,11 +40,6 @@ WebAuthnTransactionChild::RecvConfirmSign(const uint64_t& aTransactionId,
     return IPC_FAIL_NO_REASON(this);
   }
 
-  // We don't own the reference to mManager. We need to prevent its refcount
-  // going to 0 while we call anything that can reach the call to
-  // StopListeningForVisibilityEvents in WebAuthnManager::ClearTransaction
-  // (often via WebAuthnManager::RejectTransaction).
-  RefPtr<WebAuthnManagerBase> kungFuDeathGrip(mManager);
   mManager->FinishGetAssertion(aTransactionId, aResult);
   return IPC_OK();
 }
@@ -62,11 +52,6 @@ WebAuthnTransactionChild::RecvAbort(const uint64_t& aTransactionId,
     return IPC_FAIL_NO_REASON(this);
   }
 
-  // We don't own the reference to mManager. We need to prevent its refcount
-  // going to 0 while we call anything that can reach the call to
-  // StopListeningForVisibilityEvents in WebAuthnManager::ClearTransaction
-  // (often via WebAuthnManager::RejectTransaction).
-  RefPtr<WebAuthnManagerBase> kungFuDeathGrip(mManager);
   mManager->RequestAborted(aTransactionId, aError);
   return IPC_OK();
 }

dom/webauthn/tests/get_assertion_dead_object.html

@@ -3,7 +3,6 @@ support-files =
   cbor.js
   u2futil.js
   pkijs/*
-  get_assertion_dead_object.html
 skip-if = !e10s
 scheme = https
 
@@ -15,7 +14,6 @@ scheme = https
 [test_webauthn_no_token.html]
 [test_webauthn_make_credential.html]
 [test_webauthn_get_assertion.html]
-[test_webauthn_get_assertion_dead_object.html]
 [test_webauthn_override_request.html]
 [test_webauthn_store_credential.html]
 [test_webauthn_sameorigin.html]