Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

Fix a bug in annotation scoping. #76

Merged
merged 1 commit into from
Feb 8, 2017
Merged

Fix a bug in annotation scoping. #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/builders/reference.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class ReferenceBuilder extends Object
Annotation buildAnnotation([Scope scope]) {
return astFactory.annotation(
$at,
stringIdentifier(_name),
identifier(scope, _name, _importFrom),
null,
null,
null,
Expand Down
11 changes: 6 additions & 5 deletions test/e2e_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,18 +96,19 @@ void main() {
equalsSource(
r'''
import 'package:app/app.dart' as _i1;
import 'package:app/thing.dart' as _i2;
import 'dart:core' as _i2;
import 'package:app/thing.dart' as _i3;

class Injector implements _i1.App {
final _i1.Module _module;

Injector(this._module);

@override
_i2.Thing getThing() => new _i2.Thing(_module.getDep1(), _module.getDep2());
@_i2.override
_i3.Thing getThing() => new _i3.Thing(_module.getDep1(), _module.getDep2());

_i2.Thing instantiateAndReturnNamedThing() {
return new _i2.Thing.named();
_i3.Thing instantiateAndReturnNamedThing() {
return new _i3.Thing.named();
}
}
''',
Expand Down