Skip to content
This repository was archived by the owner on Aug 2, 2025. It is now read-only.

Conversation

@mit-mit
Copy link
Contributor

@mit-mit mit-mit commented Apr 26, 2021

No description provided.

@mit-mit mit-mit requested review from munificent and pq April 26, 2021 08:52
Copy link
Contributor

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. Happy to land and iterate?

pubspec.yaml Outdated
@@ -0,0 +1,11 @@
name: lints
description: Lints that represent the Dart style guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should generalize the mission statement?

Lints that enforce recommended Dart style

Official Dart lint rules

Do we want to include flutter as well?

Official Dart and Flutter lint rules

Dunno...

(Happy to land though and iterate.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to keeping this a little more general.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

name: lints
description: Lints that represent the Dart style guide
version: 0.1.0
homepage: https://dart.dev/guides/language/effective-dart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we be adding documentation of these rulesets to effective dart? If not, maybe a new targeted page?

https://dart.dev/guides/language/lints (or linting)

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference would be that effective Dart does somehow communicate what is scoring and what is recommended lints. Is that an option @munificent ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. Bob?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioning these on "Effective Dart" SGTM.

@pq pq mentioned this pull request Apr 27, 2021
README.md Outdated
@@ -0,0 +1 @@
# Dart lints
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to be published on pub? If so, it seems like the standard is not to include a title(to avoid duplication) and instead start with a description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mit-mit mit-mit merged commit c522ad9 into main Apr 27, 2021
@mit-mit mit-mit deleted the initial_files branch April 27, 2021 19:47
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants