-
Notifications
You must be signed in to change notification settings - Fork 30
Add files #1
Add files #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits. Happy to land and iterate?
pubspec.yaml
Outdated
| @@ -0,0 +1,11 @@ | |||
| name: lints | |||
| description: Lints that represent the Dart style guide | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should generalize the mission statement?
Lints that enforce recommended Dart style
Official Dart lint rules
Do we want to include flutter as well?
Official Dart and Flutter lint rules
Dunno...
(Happy to land though and iterate.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to keeping this a little more general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| name: lints | ||
| description: Lints that represent the Dart style guide | ||
| version: 0.1.0 | ||
| homepage: https://dart.dev/guides/language/effective-dart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we be adding documentation of these rulesets to effective dart? If not, maybe a new targeted page?
https://dart.dev/guides/language/lints (or linting)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference would be that effective Dart does somehow communicate what is scoring and what is recommended lints. Is that an option @munificent ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM. Bob?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioning these on "Effective Dart" SGTM.
README.md
Outdated
| @@ -0,0 +1 @@ | |||
| # Dart lints | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to be published on pub? If so, it seems like the standard is not to include a title(to avoid duplication) and instead start with a description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
No description provided.