Update to new io.stdin.supportsAnsiEscapes. #5
Conversation
|
|
||
| @override | ||
| bool get ansiSupported => io.Platform.ansiSupported; | ||
| bool get ansiSupported => io.stdin.supportsAnsiEscapes; |
There was a problem hiding this comment.
There is also now stdout.supportsAnsiEscapes. We currently don't need it, but maybe we should make sure it can be added easily in a non-confusing way? Would it make sense to call this stdinAnsiSupported?
There was a problem hiding this comment.
Works for me. I'll update.
There was a problem hiding this comment.
Hmmm. On the other hand, this would break all clients. I leave that call to you and @tvolkert. Happy either way.
There was a problem hiding this comment.
I wouldn't be too worried about that and just bump the major version number to indicate that we made incompatible API changes?
There was a problem hiding this comment.
Since it would be a breaking change, let's hold off and make the breaking change if and when such an API is added to the SDK.
There was a problem hiding this comment.
Ah, sorry. Missed you comment @tvolkert. Thanks.
|
LGTM |
3 participants
See: flutter/flutter#9051
@tvolkert @goderbauer