Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

Conversation

@dkrutskikh
Copy link
Member

@dkrutskikh dkrutskikh commented Jul 22, 2021

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@dkrutskikh dkrutskikh requested a review from incendial July 22, 2021 04:58
@dkrutskikh dkrutskikh force-pushed the prefer-single-widget-per-file-rule branch from 46540ed to bfb638d Compare July 22, 2021 05:17
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021

Codecov Report

Merging #406 (836b4e7) into master (bc56884) will increase coverage by 0.07%.
The diff coverage is 92.30%.

❗ Current head 836b4e7 differs from pull request most recent head 45960e1. Consider uploading reports for the commit 45960e1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
+ Coverage   81.04%   81.11%   +0.07%     
==========================================
  Files         166      169       +3     
  Lines        3766     3792      +26     
==========================================
+ Hits         3052     3076      +24     
- Misses        714      716       +2     
Impacted Files Coverage Δ
...c/analyzers/lint_analyzer/rules/rules_factory.dart 91.83% <0.00%> (-3.91%) ⬇️
...s_list/member_ordering_extended/config_parser.dart 100.00% <ø> (ø)
...t/prefer_single_widget_per_file/config_parser.dart 100.00% <100.00%> (ø)
...widget_per_file/prefer_single_widget_per_file.dart 100.00% <100.00%> (ø)
...es_list/prefer_single_widget_per_file/visitor.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc56884...45960e1. Read the comment docs.

@incendial incendial changed the title feat: introduce new code diagnostics `prefer-single-widget-per-file-r… feat: introduce new code diagnostics prefer-single-widget-per-file Jul 22, 2021
@dkrutskikh dkrutskikh requested a review from incendial July 22, 2021 21:54
@dkrutskikh dkrutskikh force-pushed the prefer-single-widget-per-file-rule branch 2 times, most recently from 05dc7a1 to 397e52a Compare July 23, 2021 05:01
@dkrutskikh dkrutskikh force-pushed the prefer-single-widget-per-file-rule branch from a872e6c to 911841a Compare July 25, 2021 05:24
@dkrutskikh dkrutskikh requested a review from incendial July 25, 2021 06:44
@incendial incendial added the type: enhancement New feature or request label Jul 28, 2021
@incendial incendial added this to the 4.2.0 milestone Jul 28, 2021
@dkrutskikh dkrutskikh force-pushed the prefer-single-widget-per-file-rule branch from 911841a to f2f9225 Compare July 31, 2021 09:53
@dkrutskikh dkrutskikh merged commit 12bffdf into master Aug 1, 2021
@dkrutskikh dkrutskikh deleted the prefer-single-widget-per-file-rule branch August 1, 2021 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-rules type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants