Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

Conversation

@dkrutskikh
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@dkrutskikh dkrutskikh self-assigned this Sep 18, 2021
@dkrutskikh dkrutskikh changed the title Antipatterns deps refactor: anti-pattern dependencies Sep 18, 2021
@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #460 (e4e5f55) into master (5e474ee) will decrease coverage by 0.11%.
The diff coverage is 90.19%.

❗ Current head e4e5f55 differs from pull request most recent head 3270722. Consider uploading reports for the commit 3270722 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   83.39%   83.28%   -0.12%     
==========================================
  Files         188      188              
  Lines        3831     3829       -2     
==========================================
- Hits         3195     3189       -6     
- Misses        636      640       +4     
Impacted Files Coverage Δ
...nalyzer/anti_patterns/models/obsolete_pattern.dart 50.00% <ø> (ø)
...rs/lint_analyzer/anti_patterns/models/pattern.dart 100.00% <ø> (ø)
...tterns/anti_patterns_list/long_parameter_list.dart 91.30% <88.88%> (-8.70%) ⬇️
.../lint_analyzer/anti_patterns/patterns_factory.dart 83.33% <88.88%> (+1.51%) ⬆️
.../anti_patterns/anti_patterns_list/long_method.dart 94.44% <90.90%> (-5.56%) ⬇️
lib/src/analyzers/lint_analyzer/lint_analyzer.dart 93.10% <100.00%> (ø)
lib/src/config_builder/config_builder.dart 83.33% <100.00%> (ø)
...rs/unused_files_analyzer/unused_files_visitor.dart 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e474ee...3270722. Read the comment docs.

@dkrutskikh dkrutskikh merged commit 263cf63 into master Sep 19, 2021
@dkrutskikh dkrutskikh deleted the antipatterns-deps branch September 19, 2021 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants