Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

Conversation

@dkrutskikh
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@dkrutskikh dkrutskikh requested a review from incendial October 3, 2021 14:14
@dkrutskikh dkrutskikh self-assigned this Oct 3, 2021
@dkrutskikh dkrutskikh added area-metrics type: bug Something isn't working labels Oct 3, 2021
@dkrutskikh dkrutskikh added this to the 4.4.0 milestone Oct 3, 2021
@codecov
Copy link

codecov bot commented Oct 3, 2021

Codecov Report

Merging #487 (06bd4b4) into master (eb5412c) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
- Coverage   83.73%   83.62%   -0.12%     
==========================================
  Files         199      199              
  Lines        4114     4110       -4     
==========================================
- Hits         3445     3437       -8     
- Misses        669      673       +4     
Impacted Files Coverage Δ
...alyzers/lint_analyzer/metrics/metrics_factory.dart 100.00% <100.00%> (ø)
...list/source_lines_of_code/source_code_visitor.dart 100.00% <100.00%> (ø)
lib/src/config_builder/config_builder.dart 81.81% <100.00%> (-1.52%) ⬇️
...tterns/anti_patterns_list/long_parameter_list.dart 95.65% <0.00%> (-4.35%) ⬇️
.../anti_patterns/anti_patterns_list/long_method.dart 96.36% <0.00%> (-3.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb5412c...06bd4b4. Read the comment docs.

@dkrutskikh dkrutskikh merged commit 006f077 into master Oct 3, 2021
@dkrutskikh dkrutskikh deleted the fix-source-lines-of-code branch October 3, 2021 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-metrics type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants