Started omitting instructions if they are null.

[gaaclarke]

fixes #196

This makes sure that the map for the InitializationResult doesn't include a instructions entry if the value is null.

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[gaaclarke]

This is a pretty tricky way to hide a bug. I wonder if using extension types for InitializationResult is actually buying us anything.

[gaaclarke]

I'm not sure what the release protocol is for this, do you want me to update the changelog.md and bump the version too?

[jakemac53]

Suggested change

	}) {
	final map = {
	'protocolVersion': protocolVersion.versionString,
	'capabilities': serverCapabilities,
	'serverInfo': serverInfo,
	};
	if (instructions != null) {
	map['instructions'] = instructions;
	}
	return InitializeResult.fromMap(map);
	}
	}) => InitializeResult.fromMap({
	'protocolVersion': protocolVersion.versionString,
	'capabilities': serverCapabilities,
	'serverInfo': serverInfo,
	'instructions': ?instructions,
	});

[jakemac53]

Or if our language version doesn't support that, we can do if (instructions != null) 'instructions': instructions,

[gaaclarke]

We needed 3.8 for ?instructions, done.

[jakemac53]

I'm not sure what the release protocol is for this, do you want me to update the changelog.md and bump the version too?

Yes, bump the version to 0.3.1-wip please and then add a new entry to the changelog.

[gaaclarke]

Yes, bump the version to 0.3.1-wip please and then add a new entry to the changelog.

done

[github-actions]

PR Health

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.