Parse output from flutter run with --machine #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
force-pushed
the
use_machine_output
branch
from
2cd9a48 to
e3e2fce
Compare
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
jwren
approved these changes
Oct 21, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 22, 2025
Issue description: Without this change, the dart MCP command launch_app will not work for the `chrome` device target because it won't find any DTD URI. What is the fix: This starts using the `--machine` along with `--print-dtd` arguments to the `flutter run` command, now that it prints the DTD URI in machine mode. Why cherry-pick: This will enable Flutter developers to develop web apps using the MCP server without hanging. Risk: Low, this only affects the Dart MCP server's `launch_app` command so the radius is small, and the likely worst thing that could happen is that it would stop working for other devices as well. See dart-lang/ai#301 and flutter/flutter#176655 for more information. Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/456480 Bug: dart-lang/ai#302 Change-Id: Ide1ea8d447de43a0a48fae05d40f9051457eaa2c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/456482 Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes the flutter launcher read the DTD URI from the
--machineoutput instead of parsing it fromstdout. It will still fall back to parsing it from stdout to handle (slightly) older versions of Flutter that don't print the DTD URI as part of the--machineoutput.Related Issues
--machineoutput inlaunch_app#302Tests