This repository was archived by the owner on Apr 30, 2021. It is now read-only.
Stop writing log messages to the output (issue 23596) #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/src/driver.dart
Outdated
Contributor
There was a problem hiding this comment.
This is a significant enough change that I'd prefer for it to be in its own CL. Also, we can't do this until we've updated analyzer_cli's pubspec to point to at least analyzer version 0.25.2-alpha.1, which is the first version of analyzer that has null-aware operators enabled by default. Finally, when we do make this change, I think we should a deprecation message to let the user know that the "enable null aware operators" flag is no longer needed (see #23899).
Contributor
|
Other than the issue with null-aware operators, lgtm. |
bwilkerson
added a commit
that referenced
this pull request
Jul 23, 2015
Stop writing log messages to the output (issue 23596)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stereotype441