Convert packages paths to absolute paths in file watcher #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
changed the title
lib/src/generate/watch_impl.dart
Outdated
| var changePath = e.path; | ||
|
|
||
| // Convert `packages` paths to absolute paths. | ||
| () { |
Member
There was a problem hiding this comment.
Why this lambda thingy here? Feels weird...
Contributor
Author
There was a problem hiding this comment.
Oh I just used that to encapsulate all the local variables so I didn't have to worry about using somewhat generic names. Really though I should have just broken this out into a helper method or something, I will do that instead.
Member
|
One question inline. LGTM ...you ran dartfmt, right? |
Contributor
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #109