Skip to content

Drop hardcoded list of known logger names #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2019
Merged

Drop hardcoded list of known logger names #2194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f33fae3
Drop hardcoded list of known logger names
natebosch Apr 17, 2019
7b1f708
Look for any logger name with a space
natebosch Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 5 additions & 28 deletions build_runner/lib/src/logging/std_io_logging.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ StringBuffer colorLog(LogRecord record, {bool verbose}) {
final level = color.wrap('[${record.level}]');
final eraseLine = ansiOutputEnabled && !verbose ? '\x1b[2K\r' : '';
var lines = <Object>[
'$eraseLine$level ${_loggerName(record, verbose)}${record.message}'
'$eraseLine$level ${_recordHeader(record, verbose)}${record.message}'
];

if (record.error != null) {
Expand Down Expand Up @@ -57,34 +57,11 @@ StringBuffer colorLog(LogRecord record, {bool verbose}) {
void _stdIOLogListener(LogRecord record, {bool verbose}) =>
stdout.write(colorLog(record, verbose: verbose));

/// Filter out the Logger names known to come from `build_runner` and splits the
/// header for levels >= WARNING.
String _loggerName(LogRecord record, bool verbose) {
var knownNames = const [
'ApplyBuilders',
'Bootstrap',
'Build',
'BuildConfigOverrides',
'BuildDefinition',
'BuildOptions',
'BuildScriptUpdates',
'CreateOutputDir',
'Entrypoint',
'Heartbeat',
'IOEnvironment',
'Serve',
'Watch',
'build_runner',
// commands
'build',
'clean',
'doctor',
'serve',
'test',
'watch',
];
/// Filter out the Logger names which aren't coming from specific builders and
/// splits the header for levels >= WARNING.
String _recordHeader(LogRecord record, bool verbose) {
var maybeSplit = record.level >= Level.WARNING ? '\n' : '';
return verbose || !knownNames.contains(record.loggerName)
return verbose || record.loggerName.contains(' ')
? '${record.loggerName}:$maybeSplit'
: '';
}