Skip to content

Conversation

@grouma
Copy link
Member

@grouma grouma commented Apr 23, 2019

Closes #2210

Changes:

  • Add retry logic to reading the various state files, e.g. portFile.
  • Update test daemon to better mimic actual implementations i.e. read version file
  • Add test to ensure there is no race condition
  • Rev version
    • Note that this isn't technically a breaking change as we haven't exposed the src/daemon.dart yet but it should be treated as one.

@grouma grouma requested a review from jakemac53 April 23, 2019 21:05
@googlebot googlebot added the cla: yes Google is happy with the PR contributors label Apr 23, 2019
@grouma grouma merged commit fc3d135 into master Apr 24, 2019
@grouma grouma deleted the race-condition branch April 24, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Google is happy with the PR contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build_daemon returns Version skew in a race condition

5 participants