Skip to content

Fix module_builder reading DDC modules for non-primary dart libraries. #4294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2025
Merged

Fix module_builder reading DDC modules for non-primary dart libraries. #4294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b125c96
Fix module_builder reading DDC modules for non-primary dart libraries.
Markzipan Nov 21, 2025
6298dab
bumping ver
Markzipan Nov 21, 2025
164c144
Merge branch 'master' into module_builder_fix
davidmorgan Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build_modules/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## 5.1.4

- Fix module_builder reading DDC modules for non-primary dart libraries.
- Allow Dart SDK 3.11.x and 3.12 prerelease.

## 5.1.3
Expand Down
24 changes: 13 additions & 11 deletions build_modules/lib/src/module_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,18 +55,19 @@ class ModuleBuilder implements Builder {
var outputModule = metaModule.modules.firstWhereOrNull(
(m) => m.primarySource == buildStep.inputId,
);
final serializedLibrary = await buildStep.readAsString(
buildStep.inputId.changeExtension(moduleLibraryExtension),
);
final libraryModule = ModuleLibrary.deserialize(
buildStep.inputId,
serializedLibrary,
);
final scratchSpace = await buildStep.fetchResource(scratchSpaceResource);
if (outputModule == null && libraryModule.hasMain) {
outputModule = metaModule.modules.firstWhere(
(m) => m.sources.contains(buildStep.inputId),
if (outputModule == null) {
final serializedLibrary = await buildStep.readAsString(
buildStep.inputId.changeExtension(moduleLibraryExtension),
);
final libraryModule = ModuleLibrary.deserialize(
buildStep.inputId,
serializedLibrary,
);
if (libraryModule.hasMain) {
outputModule = metaModule.modules.firstWhere(
(m) => m.sources.contains(buildStep.inputId),
);
}
}
if (outputModule == null) return;
final modules = await buildStep.fetchResource(moduleCache);
Expand All @@ -76,6 +77,7 @@ class ModuleBuilder implements Builder {
outputModule,
);
if (usesWebHotReload) {
final scratchSpace = await buildStep.fetchResource(scratchSpaceResource);
// All sources must be declared before the Frontend Server is invoked, as
// it only accepts the main entrypoint as its compilation target.
await buildStep.trackStage(
Expand Down