#3054. Add more method clozurization tests #3060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Feb 4, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good, couple of comments!
...erty_Extraction/Instance_Method_Closurization/method_closurization_named_params_A04_t01.dart
Show resolved
Hide resolved
...erty_Extraction/Instance_Method_Closurization/method_closurization_named_params_A05_t01.dart
Outdated
Show resolved
Hide resolved
...erty_Extraction/Instance_Method_Closurization/method_closurization_named_params_A05_t01.dart
Outdated
Show resolved
Hide resolved
...Extraction/Instance_Method_Closurization/method_closurization_positional_params_A04_t01.dart
Outdated
Show resolved
Hide resolved
...Extraction/Instance_Method_Closurization/method_closurization_positional_params_A05_t01.dart
Outdated
Show resolved
Hide resolved
sgrekhov
force-pushed
the
co19-3054-03
branch
from
e12063f to
bb0e190
Compare
sgrekhov
commented
Feb 4, 2025
Contributor
Author
sgrekhov
left a comment
sgrekhov
left a comment
There was a problem hiding this comment.
Thank you. Updated. PTAL
...erty_Extraction/Instance_Method_Closurization/method_closurization_named_params_A04_t01.dart
Show resolved
Hide resolved
...erty_Extraction/Instance_Method_Closurization/method_closurization_named_params_A05_t01.dart
Outdated
Show resolved
Hide resolved
...erty_Extraction/Instance_Method_Closurization/method_closurization_named_params_A05_t01.dart
Outdated
Show resolved
Hide resolved
...Extraction/Instance_Method_Closurization/method_closurization_positional_params_A04_t01.dart
Outdated
Show resolved
Hide resolved
...Extraction/Instance_Method_Closurization/method_closurization_positional_params_A05_t01.dart
Outdated
Show resolved
Hide resolved
eernstg
approved these changes
Feb 4, 2025
...erty_Extraction/Instance_Method_Closurization/method_closurization_named_params_A04_t01.dart
Show resolved
Hide resolved
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 6, 2025
2025-02-05 sgrekhov22@gmail.com dart-lang/co19#2559. Add tests for enum with empty list of values (dart-lang/co19#3066) 2025-02-04 sgrekhov22@gmail.com dart-lang/co19#3054. Add more method clozurization tests (dart-lang/co19#3060) 2025-02-04 sgrekhov22@gmail.com Fixes dart-lang/co19#3063. Add additional "correct member overrides" test (dart-lang/co19#3065) 2025-02-04 sgrekhov22@gmail.com dart-lang/co19#3054. Add more test cases to closurization tests. Part 1. (dart-lang/co19#3061) 2025-02-04 sgrekhov22@gmail.com dart-lang/co19#3054. Add generic method instantiation tests (dart-lang/co19#3062) 2025-02-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 4.6.0 to 4.7.0 in the github-actions group (dart-lang/co19#3064) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I5d1b9a2d7231b2b8f20e97e3f9da940f4632957f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408260 Reviewed-by: Alexander Thomas <athom@google.com> Auto-Submit: Sergey Grekhov <sgrekhov22@gmail.com> Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.