#3057. Add promotion tests for C-style for-loop #3153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrekhov
requested review from
athomas,
chloestefantsova and
eernstg
and removed request for
athomas
eernstg
reviewed
Apr 23, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good! Added a couple of comments about the @description.
Contributor
Author
|
Thank you! Updated. PTAL. P.S. The same changes are required in several other pull requests. I'll take care of it. |
Member
|
Sounds good, thanks! |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 25, 2025
2025-04-25 sgrekhov22@gmail.com dart-lang/co19#3122. Expect an error in case of non-constant in a constant expression (dart-lang/co19#3159) 2025-04-24 sgrekhov22@gmail.com dart-lang/co19#3057. Add return statement in loops tests (dart-lang/co19#3158) 2025-04-24 sgrekhov22@gmail.com dart-lang/co19#3057. Update instance check tests and add negated instance check ones (dart-lang/co19#3131) 2025-04-23 sgrekhov22@gmail.com dart-lang/co19#3057. Add promotion tests for C-style for-loop (dart-lang/co19#3153) 2025-04-18 sgrekhov22@gmail.com Fixes dart-lang/co19#3122. Update constants evaluation according to the specification (dart-lang/co19#3150) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: Ie89c9a3fbb920cb7e6488d652118ccc805b6f4ad Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424760 Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.