#3057. Add promotion tests for if and break statements
#3156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Apr 29, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good, with a few comments!
As usual, I'm worried that tests where significant code is dead are too confusing for future readers (they might very well think "OK, this is wrong, that's dead code!" and then proceed to delete or change the test). So it would be nice to have just one comment in the first of several cases in each of the tests that are testing the treatment of dead code.
Contributor
Author
|
Thank you. Updated. PTAL. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 2, 2025
2025-05-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 4.7.0 to 4.7.1 in the github-actions group (dart-lang/co19#3166) 2025-04-30 sgrekhov22@gmail.com dart-lang/co19#3057. Add type of interest tests. (dart-lang/co19#3161) 2025-04-30 sgrekhov22@gmail.com dart-lang/co19#3057. Update promotion via assignment tests (dart-lang/co19#3160) 2025-04-30 sgrekhov22@gmail.com dart-lang/co19#3057. Add promotion tests for `if` and `break` statements (dart-lang/co19#3156) 2025-04-29 sgrekhov22@gmail.com dart-lang/co19#3057. Add promotion tests for for-in loop (dart-lang/co19#3154) 2025-04-29 sgrekhov22@gmail.com Fixes dart-lang/co19#3151. Update constants expression tests. (dart-lang/co19#3157) 2025-04-29 sgrekhov22@gmail.com dart-lang/co19#3057. Remove obsolete `promotion_via_initialization_*` tests (dart-lang/co19#3163) 2025-04-29 sgrekhov22@gmail.com dart-lang/co19#3057. Add promotion tests for do loop and continue statement (dart-lang/co19#3155) 2025-04-29 sgrekhov22@gmail.com dart-lang/co19#3057. Fix typos in descriptions in `promotion_via_type_test_*` (dart-lang/co19#3164) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: Icf2ea16079c6998c7c8eca502c7c6f08f816b445 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426060 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.