#3057. Add null-aware method invocation tests #3162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
May 2, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good! I think it's worth taking one more look at one test which might be a little too permissive.
eernstg
reviewed
May 2, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Sorry about pushing this one more time, I have difficulties seeing how we can conclude anything new from TypeSystem/flow-analysis/reachability_A24_t04.dart. Perhaps I just need to understand better what it is intended to show.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 9, 2025
2025-05-09 sgrekhov22@gmail.com Fixes dart-lang/co19#3175. Remove forgotten code. (dart-lang/co19#3176) 2025-05-08 sgrekhov22@gmail.com dart-lang/co19#3057. Add test that the list of types of interests always contains `NonNull(declared)`. (dart-lang/co19#3172) 2025-05-07 sgrekhov22@gmail.com Fixes dart-lang/co19#3170. Fix spread collections tests (dart-lang/co19#3171) 2025-05-06 sgrekhov22@gmail.com dart-lang/co19#3057. Add null-aware method invocation tests (dart-lang/co19#3162) 2025-05-05 sgrekhov22@gmail.com dart-lang/co19#3057. Update promotion_via_assignment_A03_t02.dart according to the implementation (dart-lang/co19#3168) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I2c91d32c10f7be6050535c735ae15f8798549228 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427721 Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.