Skip to content
This repository was archived by the owner on Jan 28, 2024. It is now read-only.

Support for Dynamic linking#174

Merged
dcharkes merged 3 commits intodart-archive:masterfrom
mannprerak2:dynamic_linking
Mar 4, 2021
Merged

Support for Dynamic linking#174
dcharkes merged 3 commits intodart-archive:masterfrom
mannprerak2:dynamic_linking

Conversation

@mannprerak2
Copy link
Contributor

@mannprerak2 mannprerak2 commented Mar 4, 2021

Closes dart-lang/native#394, Closes dart-lang/native#374

  • Added lint rule unnecessary_brace_in_string_interps.
  • Added .fromLookup constructor to support dynamic linking. (173)
  • Updated version (2.0.3 => 2.1.0, changelog, examples, test.
  • Updated travis to target version2.12.0 (127).
  • Updated SDK constraints to >=2.12.0 <3.0.0.

I am not sure why we were suddenly getting info - Avoid using braces in interpolation when not needed at ... on Travis after pushing to master, but I went ahead and added this lint rule.

@mannprerak2 mannprerak2 requested a review from dcharkes March 4, 2021 05:27
Copy link
Contributor

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why we were suddenly getting info - Avoid using braces in interpolation when not needed at ... on Travis after pushing to master, but I went ahead and added this lint rule.

Me neither, but thanks for cleaning it up! 💯

  • Added .fromLookup constructor to support dynamic linking. (173)

🚀 🚀 🚀

@dcharkes dcharkes merged commit 89084d9 into dart-archive:master Mar 4, 2021
@mannprerak2 mannprerak2 deleted the dynamic_linking branch March 4, 2021 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Support dynamic linking Null-safety: Switch back to stable branch.

2 participants