-
Notifications
You must be signed in to change notification settings - Fork 388
chore(okhttp): Fix CI by setting minSdk=24 #1835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with
API leaks
|
Package | Leaked API symbol | Leaking sources |
---|---|---|
ok_http | $Certificate$NullableType | jni/bindings.dart::Certificate::nullableType |
ok_http | $Certificate$Type | jni/bindings.dart::Certificate::type |
ok_http | PublicKey | jni/bindings.dart::Certificate::verify::publicKey jni/bindings.dart::$PublicKey$NullableType jni/bindings.dart::$PublicKey$NullableType::nullableType jni/bindings.dart::$PublicKey$Type jni/bindings.dart::$PublicKey$Type::nullableType jni/bindings.dart::Certificate::verify$1::publicKey jni/bindings.dart::Certificate::verify$2::publicKey jni/bindings.dart::Certificate::getPublicKey jni/bindings.dart::X509Certificate::verify2::publicKey |
ok_http | $PublicKey$NullableType | jni/bindings.dart::PublicKey::nullableType |
ok_http | $PublicKey$Type | jni/bindings.dart::PublicKey::type |
ok_http | $PublicKey | jni/bindings.dart::PublicKey::implementIn::$impl jni/bindings.dart::PublicKey::implement::$impl |
ok_http | $X509Certificate$NullableType | jni/bindings.dart::X509Certificate::nullableType |
ok_http | $X509Certificate$Type | jni/bindings.dart::X509Certificate::type |
ok_http | $PrivateKey$NullableType | jni/bindings.dart::PrivateKey::nullableType |
ok_http | $PrivateKey$Type | jni/bindings.dart::PrivateKey::type |
ok_http | $PrivateKey | jni/bindings.dart::PrivateKey::implementIn::$impl jni/bindings.dart::PrivateKey::implement::$impl |
This check can be disabled by tagging the PR with skip-leaking-check
.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
Files |
---|
pkgs/http/example/main.dart |
This check can be disabled by tagging the PR with skip-license-check
.
Revisions updated by `dart tools/rev_sdk_deps.dart`. ecosystem (https://github.com/dart-lang/ecosystem/compare/f4fbac4..6a8746e): 6a8746e 2025-10-13 Moritz Use newest verion of firehose in publish (dart-lang/ecosystem#378) http (https://github.com/dart-lang/http/compare/2c53fa3..2cb6c12): 2cb6c12 2025-10-15 Brian Quinlan chore(cronet_http): Prepare to release 1.6.0 (dart-lang/http#1833) a906598 2025-10-16 Denys Vitali fix(ok_http): trust manager init (dart-lang/http#1830) 54dfd63 2025-10-15 Brian Quinlan docs(cupertino_http): Clarify that happens when a request is cancelled (dart-lang/http#1834) 3e3c366 2025-10-15 Brian Quinlan chore(okhttp): Fix CI by setting minSdk=24 (dart-lang/http#1835) 6271faf 2025-10-13 Benjamin feat: export MediaType from http_parser (dart-lang/http#1803) 32dee0c 2025-10-13 Benjamin chore(cronet_http): bump compileSdkVersion to 34 (dart-lang/http#1832) tools (https://github.com/dart-lang/tools/compare/adf3fe7..f5920a2): f5920a2d 2025-10-16 Morgan :) Fix `PollingDirectoryWatcher` for delete during poll. (dart-lang/tools#2212) 289ba0d3 2025-10-15 Morgan :) Add DirectoryWatcher symlink tests. (dart-lang/tools#2206) 1275d4c3 2025-10-14 Kevin Moore Bump deps for graphs, html, process, pubspec_parse (dart-lang/tools#2210) 8b9a48ca 2025-10-14 Morgan :) Fix test handling of link timestamps. (dart-lang/tools#2208) 81588f32 2025-10-14 Abgar Simonean Update to oauth2 package README for Flutter Web info (dart-lang/tools#1961) webdev (https://github.com/dart-lang/webdev/compare/186bfe7..2517aa9): 2517aa94 2025-10-13 Srujan Gaddam [DWDS] Make pause a no-op on WebSocketProxyService (dart-lang/webdev#2697) Change-Id: Ifee5e199cf5799aa5962639e686192874f4d58b3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/455480 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Fixes the failure:
caused by the emulator not supporting the old (21) SDK version.
--
Contribution guidelines:
dart format
.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.