Skip to content

[CI] Merge workflows #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2023
Merged

[CI] Merge workflows #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09769bf
[CI] Merge workflows
dcharkes Apr 20, 2023
b098ff1
try not renaming
dcharkes Apr 20, 2023
71d8461
try not renaming
dcharkes Apr 20, 2023
7a97684
rename with correct paths
dcharkes Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 0 additions & 89 deletions .github/workflows/c_compiler.yaml
View file
Open in desktop

This file was deleted.

21 changes: 11 additions & 10 deletions .github/workflows/native_assets_cli.yaml → .github/workflows/dart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,17 @@
name: package:native_assets_cli
name: dart
permissions: read-all

on:
pull_request:
branches: [main]
paths:
- ".github/workflows/native_assets_cli.yml"
- "pkgs/c_compiler/**" # Direct import of example.
- "pkgs/native_assets_cli/**"
- ".github/workflows/dart.yaml"
- "pkgs/**"
push:
branches: [main]
paths:
- ".github/workflows/native_assets_cli.yml"
- "pkgs/c_compiler/**" # Direct import of example.
- "pkgs/native_assets_cli/**"
- ".github/workflows/dart.yaml"
- "pkgs/**"
schedule:
- cron: "0 0 * * 0" # weekly

Expand All @@ -23,6 +21,7 @@ jobs:
matrix:
os: [ubuntu, macos]
sdk: [stable, dev]
package: [c_compiler, native_assets_cli]
exclude:
# Only run analyze against dev on one host.
- os: macos
Expand All @@ -32,7 +31,7 @@ jobs:

defaults:
run:
working-directory: pkgs/native_assets_cli
working-directory: pkgs/${{ matrix.package }}

steps:
- uses: actions/checkout@8f4b7f84864484a7bf31766abe9204da3cbe65b3
Expand All @@ -47,8 +46,10 @@ jobs:
if: ${{ matrix.sdk == 'stable' }}

- run: dart pub get

- run: dart pub get
working-directory: pkgs/native_assets_cli/example/native_add/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? I thought pub get recursively gets all the dependencies.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter pub get does, dart pub get doesn't.

if: ${{ matrix.package == 'native_assets_cli' }}

- run: dart analyze --fatal-infos
# Run on dev to ensure we're not depending on deprecated SDK things.
Expand All @@ -74,10 +75,10 @@ jobs:
- name: Upload coverage
uses: coverallsapp/github-action@67662d24394fd74bffcf7b462d1b432814159afd
with:
flag-name: native_assets_cli-${{ matrix.os }}
flag-name: ${{ matrix.package }}-${{ matrix.os }}
github-token: ${{ secrets.GITHUB_TOKEN }}
parallel: true
path-to-lcov: ./pkgs/native_assets_cli/coverage/lcov.info
path-to-lcov: ./pkgs/${{ matrix.package }}/coverage/lcov.info
if: ${{ matrix.sdk == 'stable' }}

coverage-finished:
Expand Down