-
Notifications
You must be signed in to change notification settings - Fork 82
[ffigen] Clean up global_test and comment out the flaky line. #1674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3821021 to
fdc7c0a
Compare
|
Of course, as soon as I put this PR out for review, it starts flaking again 😩 |
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
Might we be accidentally depending on undefined behavior in native code? |
global_test and global_native_test are exactly the same, except that one uses ordinary bindings, and the other uses
@Nativestyle bindings. They're flaky and I don't know why.Here's what I know so far: