Skip to content

[ffigen] Fix last bit of log spam #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024
Merged

[ffigen] Fix last bit of log spam #1719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkgs/ffigen/lib/src/code_generator/objc_methods.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ mixin ObjCMethods {
return oldMethod;
}

// If one of the methods is optional, and the other is required, keep the
// required one.
if (newMethod.isOptional && !oldMethod.isOptional) {
return oldMethod;
} else if (!newMethod.isOptional && oldMethod.isOptional) {
return newMethod;
}

// Check the duplicate is the same method.
if (!newMethod.sameAs(oldMethod)) {
_logger.severe('Duplicate methods with different signatures: '
Expand Down
Loading